Root to element

[nkoenig]

🎉 New feature

Summary

Adds Root::ToElement, similar to the other ToElement functions. This does change the API of World::ToElement, which I think is okay because sdf12 has not been released with the original World::ToElement function.

Test it

Run the tests.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov-commenter]

Codecov Report

Merging #842 (9309982) into sdf12 (9641718) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9309982 differs from pull request most recent head 093e6a8. Consider uploading reports for the commit 093e6a8 to get more accurate results

@@            Coverage Diff             @@
##            sdf12     #842      +/-   ##
==========================================
+ Coverage   88.48%   88.51%   +0.02%     
==========================================
  Files          92       92              
  Lines       14190    14222      +32     
==========================================
+ Hits        12556    12588      +32     
  Misses       1634     1634              

Impacted Files	Coverage Δ
src/Model.cc	92.72% <100.00%> (+0.16%)	⬆️
src/Root.cc	95.12% <100.00%> (+0.58%)	⬆️
src/World.cc	95.02% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9641718...093e6a8. Read the comment docs.

[azeey]

Can you resolve the conflicts?

[nkoenig]

Can you resolve the conflicts?

Resolved.

[azeey]

Looks great! My main question is regarding plugins

[azeey]

LGTM!

Since using ToElement(true) won't capture the effects of the param passing functionality, it would be good to mentiona that in ToElement's documentation.

One overall observation is that we have recently made efforts to avoid printing default elements and attributes (see #575) when calling sdf::Element::ToString. However, this currently doesn't work if the ElementPtr is obtained using ToElement. Should I ticket an issue?

[nkoenig]

Since using ToElement(true) won't capture the effects of the param passing functionality, it would be good to mentiona that in ToElement's documentation.

I've add documentation to the ToElement functions.

One overall observation is that we have recently made efforts to avoid printing default elements and attributes (see #575) when calling sdf::Element::ToString. However, this currently doesn't work if the ElementPtr is obtained using ToElement. Should I ticket an issue?

Yes please.

[azeey]

Ticketed #867

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1