Method showPageIndicator() Has No Effect

[dhkatz]

new paginator.Embeds()
    .setArray(embeds)
    .setAuthorizedUser(message.author)
    .setChannel(message.channel)
    .showPageIndicator(false)
    .build();

Even it I put false explicitly or leave it out the page indication still seems to show.

This seems to be because in Embeds you check for this.showPageIndicator.

discord-paginationembed/src/struct/Embeds.js

Line 395 in 07613fe

const shouldIndicate = this.showPageIndicator

But in PaginationEmbed, showPageIndicator() is actually setting this.pageIndicator

discord-paginationembed/src/struct/base/PaginationEmbed.js

Line 212 in 07613fe

this.pageIndicator = boolean;

[KyleBoyer]

Solved by PR #7

[dhkatz]

Many thanks

[dhkatz]

Also, I noticed when there is only one page the page number shows as null

Edit: Didn't actually read the PR, noticed you changed that too

[gazmull]

This bug has been fixed by the latest push on v11 branch (I assume you're using v11 branch based on the source code you have written above). Thanks to both of you!

[ogaseb]

Sorry for opening again this old issue, but the situation is actually the same as before, when there is only one page it shows null and .setPageIndicator() doesnt seem to work. Im on 1.0.1 version of your plugin and 11.5.1 of discord.js.

[gazmull]

@ProPanek Hello. Thanks for the heads up. I'll re-open this issue until it's verified and fixed.

[gazmull]

Fix pushed to NPM. (version 1.0.2)