Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix touching of relations. #43

Closed
wants to merge 1 commit into from
Closed

Fix touching of relations. #43

wants to merge 1 commit into from

Conversation

yajra
Copy link

@yajra yajra commented Nov 28, 2017 •
edited

Due to model saved callback, dirty attributes were reset and touching of relations are not being triggered.

Steps to reproduce:

  1. Create a model that extends the Node.
  2. Set $touches = ['relation'] property with some relation.

Expected Results:

  • Relation updated_at timestamp should be updated.

Actual Results:

  • Relation timestamp is not updated.

@yajra
Fix touching of relations.
7f32c82 
Due to model saved callback, dirty attributes were reset and touching of relations are not being triggered.
@coveralls
Copy link

Coverage Status

Coverage decreased (-51.4%) to 38.382% when pulling 7f32c82 on yajra:patch-touches into 8c947f2 on gazsp:master.

@gazsp
Copy link
Owner

gazsp commented Sep 23, 2018

Can we have a unit test for this please? Thanks.

@yajra yajra closed this Oct 16, 2022
@yajra yajra deleted the patch-touches branch October 16, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yajra @coveralls @gazsp