Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted all admonition boxes to new markup (#100) #101

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

djedditt
Copy link
Contributor

@djedditt djedditt commented Feb 4, 2024

Resolves (#86) and (#100)

@exelotl
Copy link
Member

exelotl commented Feb 4, 2024

Thanks a bunch! You just missed one here:

tonc/content/regobj.md

Lines 181 to 190 in 32179fc

<div class="note">
<div class="nhgood">
Force alignment on OBJ_ATTRs
</div>
As of devkitARM r19, there are new rules on struct alignments, which means that structs may not always be word aligned, and in the case of `OBJ_ATTR` structs (and others), means that `struct` copies like the one in `oam_update()` later on, will not only be slow, they may actually break. For that reason, I will force word-alignment on many of my structs with `ALIGN4`, which is a macro for `__attribute__((aligned(4)))`. For more on this, see the section on [data alignment](bitmaps.html#ssec-data-align).
</div>

@djedditt
Copy link
Contributor Author

djedditt commented Feb 4, 2024

Oops! Added in 1f198c9.

@exelotl exelotl merged commit 1f198c9 into gbadev-org:master Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants