New "Setting up a development environment" chapter #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good to review now! I think there's still plenty of improvements that could be made to first.md but they can come later - all the content in its current state hopefully flows properly and doesn't leave the reader wondering "where did that come from??" |
avivace
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Amazing, thanks @exelotl . I started taking a look at it.
Could you move the "notes", "warning" and "danger" boxes (if any) to new admonition boxes we have? The syntax is very simple:
:::<TYPE> Title
Body of the box
:::
<TYPE> can be tip, warning or danger
avivace
pushed a commit
that referenced
this pull request
Dec 20, 2023
avivace
pushed a commit
that referenced
this pull request
Dec 20, 2023
Clean up CSS and make <dfn> tags bold-italic first.md: replace <tt> with italics setup.md/first.md content changes setup.md: - Explain manual build steps - Reword some things - Ensure what's explained matches what's mentioned in first.md first.md: - Remove hand-rolled Makefile - Remove reference to Programmer's Notepad - Point to community instead of 'troubleshooting' section which no longer exists Minor formatting/style tweaks Remove metadata setup.md switch to new admonition syntax Remove -mthumb-interwork from build steps example
Clean up CSS and make <dfn> tags bold-italic first.md: replace <tt> with italics setup.md/first.md content changes setup.md: - Explain manual build steps - Reword some things - Ensure what's explained matches what's mentioned in first.md first.md: - Remove hand-rolled Makefile - Remove reference to Programmer's Notepad - Point to community instead of 'troubleshooting' section which no longer exists Minor formatting/style tweaks Remove metadata setup.md switch to new admonition syntax Remove -mthumb-interwork from build steps example
avivace
pushed a commit
that referenced
this pull request
Dec 20, 2023
djedditt
pushed a commit
to djedditt/tonc
that referenced
this pull request
Feb 4, 2024
djedditt
pushed a commit
to djedditt/tonc
that referenced
this pull request
Feb 4, 2024
Clean up CSS and make <dfn> tags bold-italic first.md: replace <tt> with italics setup.md/first.md content changes setup.md: - Explain manual build steps - Reword some things - Ensure what's explained matches what's mentioned in first.md first.md: - Remove hand-rolled Makefile - Remove reference to Programmer's Notepad - Point to community instead of 'troubleshooting' section which no longer exists Minor formatting/style tweaks Remove metadata setup.md switch to new admonition syntax Remove -mthumb-interwork from build steps example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has taken a while, and there's a bit more to do, sorry!
The
setup.mdchapter itself is in good shape but there are fixes to be made to the following chapter(s), as they refer to things that made sense in relation to the old setup chapter but not this new one. For example:I've made a start on fixing some of this stuff in the
first.mdchapter, will follow up with some more commits soon. In the meantime, I figured it'd be good to get this PR up and get some feedback on it. Enjoy!Fix #2