state: make EIP-158 ignore history block hash contract address #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
changed the title
jsign
changed the title
gballet
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
I was surprised at first because I made about the same test, and it was saying that everything worked. And this morning I realize that I had swapped the == and != 🤦♂️ I will commit my fixed test as well, even though it's kind of redundant, Testing never hurts. LGTM and thank you for giving it a look 🤝
| @@ -682,6 +682,12 @@ func TestProcessVerkleiInvalidContractCreation(t *testing.T) { | |||
| if stemStateDiff.SuffixDiffs[0].Suffix != 65 { | |||
| t.Fatalf("invalid suffix diff value found for BLOCKHASH contract at block #2: %d != 65", stemStateDiff.SuffixDiffs[0].Suffix) | |||
| } | |||
| if stemStateDiff.SuffixDiffs[0].NewValue == nil { | |||
There was a problem hiding this comment.
That's strange because that's what I did yesterday as well and it was finding non-nil. That was for the first block. But I see the tests passing so it's got to be correct.
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug regarding the post-value of the history block hash contract being
unchanged.The reason is that EIP-158 was (correctly) deleting the account for this address since the code, balance, and nonce are zero.
I've confirmed this reproduced in the current test and added extra checks to enforce that it can't happen again (since the tests assertions where checking that the key was in the witness, but not the post-state value expectation).