fix addr alignment in witness #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
force-pushed
the
jsign-fix-align
branch
from
e669957
to
dace7a3
Compare
jsign
commented
Feb 7, 2024
| @@ -244,7 +244,7 @@ type branchAccessKey struct { | |||
|
|
|||
| func newBranchAccessKey(addr []byte, treeIndex uint256.Int) branchAccessKey { | |||
| var sk branchAccessKey | |||
| copy(sk.addr[:], addr) | |||
| copy(sk.addr[20-len(addr):], addr) | |||
There was a problem hiding this comment.
If len(addr)<20 this was doing the copy incorrectly.
Another option for this particular bug case is not doing this code line change, and do:
But I think this proposed change is more general, and if we have a similar situation in other place the current fix would cover it.
Open to opinions though.
gballet
approved these changes
Feb 7, 2024
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem in EXTCODESIZE when the slot value had a value <20 bytes.