Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestProcessVerkle* tests #410

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Apr 5, 2024

The TestProcessVerkle* tests weren't updated after the PR that changed the way we calculate tree keys.

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign requested a review from gballet April 5, 2024 15:12
@jsign jsign changed the title Fix tests Fix TestProcessVerkle* tests Apr 5, 2024
Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, LGTM

@gballet gballet merged commit 9188dd1 into kaustinen-with-shapella Apr 6, 2024
3 of 4 checks passed
gballet pushed a commit that referenced this pull request May 7, 2024
* core: fix TestProcessVerkleInvalidContractCreation

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* core: fix TestProcessVerkleContractWithEmptyCode

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add separate action for testprocessverkle tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet pushed a commit that referenced this pull request May 8, 2024
* core: fix TestProcessVerkleInvalidContractCreation

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* core: fix TestProcessVerkleContractWithEmptyCode

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add separate action for testprocessverkle tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet pushed a commit that referenced this pull request May 8, 2024
* core: fix TestProcessVerkleInvalidContractCreation

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* core: fix TestProcessVerkleContractWithEmptyCode

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add separate action for testprocessverkle tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet pushed a commit that referenced this pull request May 8, 2024
* core: fix TestProcessVerkleInvalidContractCreation

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* core: fix TestProcessVerkleContractWithEmptyCode

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* add separate action for testprocessverkle tests

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants