trie/utils: simplify GetTreeKeyWithEvaluatedAddress #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
force-pushed
the
jsign-opt-gettreekeyevaladdr
branch
from
0942032
to
fc7e8ef
Compare
jsign
commented
Apr 18, 2024
| // little-endian, 32-byte aligned treeIndex | ||
| var index [32]byte | ||
| for i := 0; i < len(treeIndex); i++ { | ||
| binary.LittleEndian.PutUint64(index[i*8:(i+1)*8], treeIndex[i]) | ||
| } | ||
| verkle.FromLEBytes(&poly[3], index[:16]) | ||
| verkle.FromLEBytes(&poly[4], index[16:]) | ||
| trieIndexBytes := treeIndex.Bytes32() | ||
| verkle.FromBytes(&poly[3], trieIndexBytes[16:]) | ||
| verkle.FromBytes(&poly[4], trieIndexBytes[:16]) |
There was a problem hiding this comment.
This changes avoid this loop and copying stuff to that auxiliary index.
Note this is the same trick we did in GetTreeKey(...) (L96 in this file).
Comment on lines
+117
to
+132
| func BenchmarkGetTreeKeyWithEvaluatedAddress(b *testing.B) { | ||
| var buf [32]byte | ||
| rand.Read(buf[:]) | ||
| addrpoint := EvaluateAddressPoint(buf[:]) | ||
|
|
||
| rand.Read(buf[:]) | ||
| n := uint256.NewInt(0).SetBytes32(buf[:]) | ||
|
|
||
| _ = verkle.GetConfig() | ||
|
|
||
| b.ReportAllocs() | ||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| _ = GetTreeKeyWithEvaluatedAddess(addrpoint, n, 0) | ||
| } | ||
| } |
There was a problem hiding this comment.
Out of curiosity I added this benchmark to compare the pre and post change, and didn't notice any significant speedup.
In any case, avoiding an auxiliary array and copying is good both for doing less work, and also a more compact implementation. (and, if you mind, a closer match to GetTreeKey(...) since there's no reason why doing the same thing in different ways).
gballet
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a slight change in
GetTreeKeyWithEvaluatedAddresswhich allows to avoid copying the tree index to a separate array to accommodate for endianness.This is a trick I introduced a long ago in
GetTreeKey(...)but was just missing in this other variant.