remove unused deployment detection code #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Apr 29, 2024
| @@ -256,7 +254,6 @@ func (evm *EVM) Call(caller ContractRef, addr common.Address, input []byte, gas | |||
| // The depth-check is already done, and precompiles handled above | |||
| contract := NewContract(caller, AccountRef(addrCopy), value, gas) | |||
| contract.SetCallCode(&addrCopy, evm.StateDB.GetCodeHash(addrCopy), code) | |||
| contract.IsDeployment = creation | |||
There was a problem hiding this comment.
for creation to be true, it means that the account did not exist (check L198). If the account does not exist, then len(code) == 0 on L249. So IsDeployment is never true.
This variable is used when calling (*EVM).create but not (*EVM).Call.
jsign
approved these changes
Apr 29, 2024
gballet
added a commit
that referenced
this pull request
May 7, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the geth review of the eip 4762 PR, we identified that
IsDeploymentwas set at a location that was not necessary. This PR cleans it up inkaustinen-with-shapellaas well, ahead of a rebase.