add quick conversion test #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
May 4, 2024
|
Fixes #428 |
gballet
added a commit
that referenced
this pull request
May 7, 2024
* add quick conversion test * add debug traces * activate debug rpc * where I discover I have an outdated version of geth on my desktop
gballet
added a commit
that referenced
this pull request
May 8, 2024
* add quick conversion test * add debug traces * activate debug rpc * where I discover I have an outdated version of geth on my desktop
gballet
added a commit
that referenced
this pull request
May 8, 2024
* add quick conversion test * add debug traces * activate debug rpc * where I discover I have an outdated version of geth on my desktop
gballet
added a commit
that referenced
this pull request
May 8, 2024
* add quick conversion test * add debug traces * activate debug rpc * where I discover I have an outdated version of geth on my desktop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be part of #426 but was broken when the traces that this was relying on were removed.
Luckily, a new debug RPC call was added to help kurtosis testing the holesky conversion. This test now uses this RPC call.