Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Application Default Credentials #1

Merged
merged 5 commits into from
Dec 16, 2023

Conversation

niciliketo
Copy link
Contributor

support for Application default credentials

https://cloud.google.com/docs/authentication/application-default-credentials

It may be useful to support ADC, especially if the client code will run inside GCP environments.

  • Add this as a 3rd option for authentication in client.rb
  • Add details to the README.md
  • Add a devcontainer.json file to make development in vscode devcontainers easier

vscode devcontainer.json to allow containerised development
https://cloud.google.com/docs/authentication/application-default-credentials

It may be useful to support ADC, especially if the client code will run inside GCP environments.

- Add this as a 3rd option for authentication in client.rb
- Add details to the README.md
@gbaptista
Copy link
Owner

@niciliketo, thank you for your contribution! It's definitely helpful.

I'm reading the documentation you shared and taking a look at the PR.

@gbaptista
Copy link
Owner

That looks great.

I took the liberty of changing a few things before merging:

  • Rearranged the README to include extra details about this authentication method at the top of your contributions.
  • Removed scopes from get_application_default (I tested, and apparently we don't need them).
  • Added .devcontainer/devcontainer.json to .gitignore.
  • Applied RuboCop corrections.

Hope that's okay; feel free to open another PR if you prefer to change something.

Thank you very much for your contribution. I will issue a new Gem version throughout the day.

@gbaptista gbaptista merged commit a3bd68a into gbaptista:main Dec 16, 2023
@gbaptista
Copy link
Owner

New version released and available: https://github.com/gbaptista/gemini-ai/releases/tag/v2.1.0

@niciliketo niciliketo deleted the gcp_default_credentials branch December 16, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants