fix: Avoid the resize loop by fixing the rounding error in the retina…

…Scale function.
gbaron · Dec 17, 2022 · 23525ab · 23525ab
1 parent f70d6af
commit 23525ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -295,8 +295,8 @@ class Chart {
     const newRatio = options.devicePixelRatio || this.platform.getDevicePixelRatio();
     const mode = this.width ? 'resize' : 'attach';
 
-    this.width = newSize.width;
-    this.height = newSize.height;
+    this.width = Math.floor(newSize.width);
+    this.height = Math.floor(newSize.height);
     this._aspectRatio = this.aspectRatio;
     if (!retinaScale(this, newRatio, true)) {
       return;

diff --git a/src/helpers/helpers.dom.ts b/src/helpers/helpers.dom.ts
@@ -222,9 +222,6 @@ export function retinaScale(
   const deviceHeight = Math.floor(chart.height * pixelRatio);
   const deviceWidth = Math.floor(chart.width * pixelRatio);
 
-  chart.height = deviceHeight / pixelRatio;
-  chart.width = deviceWidth / pixelRatio;
-
   const canvas = chart.canvas;
 
   // If no style has been set on the canvas, the render size is used as display size,