This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
Handle when REMOTE_ADDR is undef, such as when using Unix socket #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the module does work correctly without this change, a warning is emitted on every request, polluting logs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REMOTE_ADDRin the PSGI environment will beundefwhen the PSGI app is run using a Unix socket. While the module does work correctly without this change, a warning is emitted on every request, which causes lots of noise in the PSGI logs. Please consider merging this, and let me know if I should make any changes. Thank you!