Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert light images in dark themes #367

Open
avivace opened this issue Oct 1, 2021 · 1 comment
Open

Invert light images in dark themes #367

avivace opened this issue Oct 1, 2021 · 1 comment
Labels
consistency - style Content format, text style, consistency in presenting the informations

Comments

@avivace
Copy link
Sponsor Member

avivace commented Oct 1, 2021

CSS filter: invert(1.0) can be easily applied to almost every image when a dark theme is selected. The result is very nice and will allow us to not rewrite/redesign every image for the dark themes.

However, we need a "not-invert" class for the images for which this effect doesn't work very well or the "themed" SVG already pointing to the CSS variables of the selected theme.
@avivace avivace added the consistency - style Content format, text style, consistency in presenting the informations label Oct 1, 2021
@ISSOtm
Copy link
Member

ISSOtm commented Oct 2, 2021

The "themed" SVGs don't use the <img> tag, so they wouldn't be affected anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consistency - style Content format, text style, consistency in presenting the informations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avivace @ISSOtm