Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow noncontiguous SECTION FRAGMENTs #655

Closed
Rangi42 opened this issue Dec 21, 2020 · 4 comments
Closed

Allow noncontiguous SECTION FRAGMENTs #655

Rangi42 opened this issue Dec 21, 2020 · 4 comments

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Dec 21, 2020

This would address a situation that comes up sometimes in pokered and pokecrystal, where two related chunks of code in a bank have something unrelated in-between them. This has been noted by the in-progress sectionful refactor for pokecrystal.

It would go further toward addressing #244, although this would still apply the same constraints to all FRAGMENTs, which SECTION "Part 2", ROMX, BANK["Part 1"] would presumably not.

@aaaaaa123456789
Copy link
Member

At some point this doesn't feel like a fragment. I'd say this would call for a new placement attribute. Perhaps BANK["section"] (instead of a number) to place it in the same bank as some other section?

@Rangi42
Copy link
Contributor Author

Rangi42 commented Dec 21, 2020

Yes, that's what #244 is requesting. This is different but related. (Consider a function and the data table it uses, separated by some unrelated thing; I'd say those are fragments of the same section.)

@aaaaaa123456789
Copy link
Member

The question is, what defines a section, if not contiguity? What you're describing sounds more like a group of sections than like a single section.

@ISSOtm
Copy link
Member

ISSOtm commented Dec 21, 2020

I agree that this wouldn't be a fragment anymore, so it would be something else. SECTION FRAGMENT is only intended to allow a given SECTION to span different input files, but that's it, especially given how they're implemented. Since the scope is different, I'd rather have the discussion continue in #244.

@ISSOtm ISSOtm closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants