Allow definition of WRAM as a contiguous segment from C000 - DFFF (i.e. DMG, SGB) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#60 takes a different approach to the same problem. |
AntonioND
requested changes
Feb 26, 2017
| @@ -10,6 +10,7 @@ | |||
| extern SLONG options; | |||
| #define OPT_SMALL 0x01 | |||
| #define OPT_SMART_C_LINK 0x02 | |||
| #define OPT_CONTWRAM 0x04 | |||
There was a problem hiding this comment.
Please, change the space here by a tab, and align the 3 elements.
| @@ -131,7 +131,7 @@ area_AllocAbsAnyBank(SLONG org, SLONG size, enum eSectionType type) | |||
|
|
|||
| SLONG startBank = SECT_ATTRIBUTES[type].bank; | |||
| SLONG bankCount = SECT_ATTRIBUTES[type].bankCount; | |||
|
|
|||
There was a problem hiding this comment.
Don't fix the whitespace, or do it in another commit.
|
In the end I've fixed the conflicts myself. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the
-wflag to make this happen