Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase version number to 0.3.8 #325

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Feb 19, 2019

Last version released is 0.3.8, but package version still shows 0.3.7.

@jmle jmle changed the base branch from master to develop February 19, 2019 23:14
@AntonioND
Copy link
Member

Oh... great, I forgot. I guess I'll have to remove that tag and create another one...

@AntonioND
Copy link
Member

It should be fine, I guess. The binaries I built all say 0.3.8 because they got the version from the git tag, so I don't actually have to replace them, I only need to update the source tarball.

@fxcoudert
Copy link

Due to the retag, rgbds fails to build in Homebrew now (which checks the commit reference as well as tag, for safety reasons). Homebrew/homebrew-core#37115

Please try to stick to semantic versioning, where a version number is not reused for a different source file / source state, once it has been released.

@AntonioND
Copy link
Member

Sorry about that. I've done it because if not there was no way to tell the two releases apart if you downloaded the tarball. I didn't know it was going to cause problems in homebrew (that check makes perfect sense).

I'm actually surprised someone uses the tarball, I imagined everyone would just clone the repository, and I was going to not provide the tarball anymore...

@bentley
Copy link
Contributor

bentley commented Feb 20, 2019

The tarball is important for packaging, because package systems generally require stable checksums. GitHub’s autogenerated tarballs are nondeterministic and can change (and have changed) in response to changes in GitHub’s backend architecture: updates to git, gzip, tar, etc. Sometimes you’ll even get different tarballs depending on your geographic location (i.e., downloading from one or another of GitHub’s CDN endpoints).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants