Backtick no gfx #95
Closed
Backtick no gfx #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This apparently does matter.
|
What's the point in a base 4 prefix? I think that it should be kept like it is now for backwards compatibility. Also, it can be used for adding a few bytes of graphics data when a full png is overkill. I don't see the point in this change. |
|
I agree. ``` has always represented planar graphics, not base 4. In general, I’m reluctant to delete features that will cause code written for “classic” RGBDS to no longer build. Side note: please be careful not to include commits from other pull requests when making a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can start to remove gbgfx functionality from rgbasm as we phase in rgbgfx.