-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mention an import function > Use python-dwca-reader instead #28
Conversation
It might also be interesting to produce some tutorial/cookbook that shows a complete example of:
So we keep the advantage of having well separated packages (each do one thing, but do it well), but a new user also as a complete, working example he/she can start from. I'm also willing to help for that, if there's interest (after July 1st) |
@niconoe, that would be great. FYI, the second step (download resulting file), can be done with |
I like the idea of providing some cookbook as suggested by @niconoe. A jupyter notebook would be a perfect environment to create such a cookbook. All three listed steps are already provided by either pygbif or dwca-reader:
|
Thanks @peterdesmet, I wasn't sure about this second step! |
Such notebooks could actually be added to https://github.com/sckott/pygbif/tree/master/demos, with one for each module:
|
Thanks!
Right, sorry, mentioned it before creating it :)
right, that was the plan, but sounds good to not include that functionality in this library
great, thanks! |
open a new issue for the cookbook(s)? |
The documentation currently mentions a
download_import
function at https://github.com/sckott/pygbif/blob/beb3a42c837c71cafb1e2d5808f968fe0d44c5ee/pygbif/occurrences/download.py#L363. That function does not exist for the moment.I assume this function would be able to open and read a GBIF download file? As was already suggested in the GBIF api-users email thread, I would also strongly suggest to use @niconoe's https://github.com/BelgianBiodiversityPlatform/python-dwca-reader, which has the very specific scope to read DwC-A (source ones and GBIF downloads). In fact, I would not even include the functionality to read such files in pygbif, but keep the scope of this package to “interact with GBIF services”.
So, I have updated the documentation to reference the python-dwca-reader instead of the non-existing download_import function. I’ve also rephrased some of the documentation, e.g. it no longer mentions a download speed, which really depends on your network connection.