Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback_message repeats inside of HipChat #247

Closed
bcarpio opened this issue Mar 22, 2014 · 2 comments
Closed

callback_message repeats inside of HipChat #247

bcarpio opened this issue Mar 22, 2014 · 2 comments
Labels
#regression type: bug

Comments

@bcarpio
Copy link

bcarpio commented Mar 22, 2014

Playing with the callback_message example from the documentation, it works just fine when I run it from err.py -T however when I actually run err and connect to HipChat, once I type the "keyword" from the example "cookie" the message repeats over and over and over again.

Possibly there is a bug in the example, I am not sure I haven't figured out how to fix it yet.
@apophys
Copy link
Contributor

apophys commented Mar 23, 2014

Hi,

these may provide some directions. #98 #99

@zoni zoni closed this as completed in c4420be Mar 23, 2014
@zoni
Copy link
Member

zoni commented Mar 23, 2014

This was a regression, sorry :( You can find the details in my commit message, but it's fixed now.

zoni pushed a commit to zoni/errbot that referenced this issue Mar 23, 2014
Ignore messages from self
1ce5d05 
This ensures messages from ourselves don't end up trickling back into
callback_message, triggering a potential loop. This code was already
introduced previously in 4053eb6, but
was lost when the xmpp back-end was refactored extensively during the
move from xmmppy to sleekxmpp (the commit which actually removed it was
9a05e7f).

Fixes errbotio#247
@zoni zoni added bug labels Mar 23, 2014
@brycied00d brycied00d mentioned this issue Dec 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#regression type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zoni @apophys @bcarpio