Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug to download and build gtest also when being a cmake subproject #48

Merged
merged 1 commit into from
May 30, 2024

Conversation

alexg-k
Copy link

@alexg-k alexg-k commented May 29, 2024

I included this repo as a git submodule in my project and included it via the add_subdirectory(lib/CppLinuxSerial) command in my top-level CMakeLists.txt to the build environment.

Right now the build then fails with the message:

CMake Error at lib/CppLinuxSerial/CMakeLists.txt:23 (message):
  CMake step for googletest failed: No such file or directory

With this pull request this error is resolved and the build succeeds.

@gbmhunter gbmhunter merged commit cf0520e into gbmhunter:master May 30, 2024
1 check passed
@gbmhunter
Copy link
Owner

Thanks @alexg-k for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants