-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Session for HTTP requests #738
Closed
Closed
Commits on Aug 2, 2021
-
Include a default requests.Session as part of settings that is used for HTTP requests to OSM APIs, and can be overridden using the utils.config. This should improve performance by re-using the underlying TCP connection when sending multiple requests to the same host, and allows a user of osmnx to override the session to provide client/server certificates when making request to any OSM API that uses 2-way SSL verification.
Configuration menu - View commit details
-
Copy full SHA for db6f76f - Browse repository at this point
Copy the full SHA db6f76fView commit details
Commits on Aug 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aa69248 - Browse repository at this point
Copy the full SHA aa69248View commit details
Commits on Aug 10, 2021
-
Update downloader.py to fix out-of-scope variable.
Configuration menu - View commit details
-
Copy full SHA for 7584155 - Browse repository at this point
Copy the full SHA 7584155View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4f05fe - Browse repository at this point
Copy the full SHA a4f05feView commit details -
Re-format code using black (for line length)
Configuration menu - View commit details
-
Copy full SHA for e2235c8 - Browse repository at this point
Copy the full SHA e2235c8View commit details -
Merge branch 'use-requests-session' of https://github.com/hokieg3n1us…
…/osmnx into use-requests-session
Configuration menu - View commit details
-
Copy full SHA for 63559e1 - Browse repository at this point
Copy the full SHA 63559e1View commit details -
Switched to Ubuntu dev machine to properly run lint_test.sh, after introducing formatting issue through Github merge conflict interface.
Configuration menu - View commit details
-
Copy full SHA for afe903b - Browse repository at this point
Copy the full SHA afe903bView commit details
Commits on Aug 12, 2021
-
Update docstring and remove redundant solution to load balanced service.
Updated docstring to better describe how to use session. Since Session creates a persistent TCP connection that is used when requests are sent to the same host/port, remove redundant fix from #699. Unable to duplicate network error from tests after running multiple times on Python 3.6, 3.7, 3.8, and 3.9.
Configuration menu - View commit details
-
Copy full SHA for fbbf5af - Browse repository at this point
Copy the full SHA fbbf5afView commit details -
Refactor to resolve server closing connection
Diagnosing the intermittent test failures, determined that the root cause was the server closing the connection due to inactivity. Refactored the settings to expose a dictionary of attributes that can be configured for a requests.Session that is instantiated when a call is made to _osm_network_download, _osm_geometries_download, or nominatum_request. Less elegant, but should allow users to provide authentication and 2-way SSL configuration, while also improving performance during repeated calls to the overpass API.
Configuration menu - View commit details
-
Copy full SHA for bdf95c7 - Browse repository at this point
Copy the full SHA bdf95c7View commit details -
Check key exists in session_config
Properly check if key exists in session_config, so a user can only provide keys as necessary for their environment.
Configuration menu - View commit details
-
Copy full SHA for de82017 - Browse repository at this point
Copy the full SHA de82017View commit details -
moving files used for local testing of different python versions
Configuration menu - View commit details
-
Copy full SHA for 3c35302 - Browse repository at this point
Copy the full SHA 3c35302View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.