Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate folium module in favor of GeoPandas explore #957

Merged
merged 11 commits into from
May 25, 2023
Merged

Deprecate folium module in favor of GeoPandas explore #957

merged 11 commits into from
May 25, 2023

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented May 22, 2023

Resolves #802 and #935.

  • Deprecates the folium module in favor of using the more powerful and flexible GeoPandas.GeoDataFrame.explore directly. GeoPandas docs. See also.
  • Adds a new route_to_gdf helper function to the utils_graph module to make it easy to explore a route
  • Deprecates the get_route_edge_attributes function as it becomes redundant with the superior route_to_gdf

See gboeing/osmnx-examples#64 for demonstration code in the examples repo. You can:

  • interactively explore nodes, edges, or both together, optionally colored by attribute values
  • interactively explore a route
  • interactively explore building footprints, transit, amenities, etc

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #957 (26d9d54) into main (1eab896) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          24       24           
  Lines        2348     2357    +9     
=======================================
+ Hits         2298     2307    +9     
  Misses         50       50           
Impacted Files Coverage Δ
osmnx/folium.py 100.00% <100.00%> (ø)
osmnx/utils_graph.py 97.64% <100.00%> (+0.08%) ⬆️

@gboeing gboeing changed the title deprecate folium module Deprecate folium module in favor of GeoPandas explore May 23, 2023
@gboeing
Copy link
Owner Author

gboeing commented May 23, 2023

@PyMap I believe this covers all the uses you had considered in #802. See gboeing/osmnx-examples#64 for demonstrations.

@gboeing gboeing merged commit ef7bfb5 into main May 25, 2023
6 checks passed
@gboeing gboeing deleted the folium branch May 25, 2023 00:00
@gboeing gboeing mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Point geometries in folium module to plot nodes interactively
1 participant