Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new newznab bookstrap theme #141

Open
lilHermit opened this issue May 3, 2016 · 9 comments
Open

Add support for new newznab bookstrap theme #141

lilHermit opened this issue May 3, 2016 · 9 comments

Comments

@lilHermit
Copy link

Please add support for the new newznab theme/template called bookstrap. Please see screengrab
screenshot from 2016-05-03 14-47-28

@ppslim
Copy link
Collaborator

ppslim commented May 3, 2016

Do you have access to such a service and willing to provide some technical details to assist?

Without access to a page rendered in that theme, there is little to see on why the current selectors do not work, or what needs adding / changed to get it running.

@lilHermit
Copy link
Author

lilHermit commented May 3, 2016

Yeah I can give you access to an install, email me at lilhermit2426@forward.cat and I'll send over the details. (Email valid for 1 week)

Edit: Extended email validity until 16/05/16

@lilHermit
Copy link
Author

bump ;-)

@ppslim
Copy link
Collaborator

ppslim commented May 18, 2016

Sorry, I had not seen a way for you to send it.

I note the email address may now be invalid, but I have emailed it regardless. It may be best to try and catch me before the weekend as time is not my friend recently.

@lilHermit
Copy link
Author

Ok try email me here lilhermit@forward.cat and we'll get things rolling. I can certainly set you up asap

@ppslim
Copy link
Collaborator

ppslim commented May 19, 2016

Having had a quick scan, there are a number of factors.

Detecting and inserting looks does not appear to be too difficult, however...

The template purposefully comments out the RSSTOKEN input field and means the API key cannot be extracted from the DOM easily.

The API for getting the NZB file itself looks to be very different, which may mean a different submission mechanism.

Overall, this may be difficult and easy in one. I should get around to looking in more detail this weekend.

@lilHermit
Copy link
Author

Ok let me know if there anything you need. In the meantime I'll do a source update to see if anything has changed with the theme

ppslim added a commit to ppslim/sabconnectplusplus that referenced this issue May 19, 2016
@ppslim
Copy link
Collaborator

ppslim commented May 19, 2016

I have done a first pass at the selectors required for this.

The page structure has changed a lot, but that isn't unexpected given this is a Bootstrap page.

The List & Cover views are covered in this, however, they will now download to sab yet, just render links.

You would need to install a local extension to test this after downloading from my iss141 branch ppslim/sabconnectplusplus@218d9b8

@lilHermit
Copy link
Author

Looks good I see the rendering of the buttons!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants