Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min and max length criteria #71

Open
sejmodha opened this issue Jan 24, 2024 · 1 comment
Open

min and max length criteria #71

sejmodha opened this issue Jan 24, 2024 · 1 comment

Comments

@sejmodha
Copy link

Hi There,

Thanks for developing this cool tool! It is indeed very useful for polishing assemblies.

I recently came across an issue whereby dnaapler was failing when a custom sequence specified for reorientation did not exist in one of the contigs in a multi-FASTA file. Ideally, an option to exclude/include length criteria could easily fix such an error by excluding such short/long contigs from the reorientation step and adding them onto the final results as it is.

Additionally, I noted that the bulk option can only be used for a multi-FASTA and fails when the input is a single sequence FASTA file. This causes a bit of an issue when such a tool is integrated into a workflow or a pipeline as typically the output or number of contigs generated using a de novo assembly step is unknown.

Thanks once again for developing dnaapler.
Sej

@gbouras13
Copy link
Owner

Hi @sejmodha ,

Thanks for the kind words mate.

With the first option, I will have a look into it - do you have an example input to share? I have not come across this bug before.

With the second option - I can relax this if you think it would be useful.

George

gbouras13 added a commit that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants