Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close button drawermenu and Added Double Quotes #94

Closed

Conversation

Babuprasanth27
Copy link
Contributor

Added Double Quotes to DrawerMenu

@Babuprasanth27
Copy link
Contributor Author

@jarmentor @gbowne1 Sorry, I have made another PR. So please review it.

@jarmentor
Copy link
Collaborator

just noting that this PR is related to #93

  • checked out this change locally for testing and review for merge
  • manually reviewed code for errors etc

This is functionally good to merge, the only issue to resolve is some code styling things with prettier.

@Babuprasanth27 - no worries! Thanks for your PR. If you could run npm run preflight:fix on your code and recommit the changes to the branch, that should resolve the check issues.

Despite the double quote fix (and thank you for that) , it looks like it's fussing about it being on one line.

Screenshot 2024-06-24 at 8 59 50 AM
Screenshot 2024-06-24 at 8 58 04 AM

Now Its works fine
@Babuprasanth27
Copy link
Contributor Author

@jarmentor Please review the recent code I have committed.

@gbowne1
Copy link
Owner

gbowne1 commented Jun 24, 2024

@jarmentor @Babuprasanth27 not sure what to do here. Now that there's basically two PRs with the same.

Yee its important to run the npm run preflight:fix before you commit and push to your PR branch. If its not already it should be in our contribution documentation.

@gbowne1
Copy link
Owner

gbowne1 commented Jun 25, 2024

Closing this PR as a duplicate of #93

@gbowne1 gbowne1 closed this Jun 25, 2024
@Babuprasanth27 Babuprasanth27 deleted the add-close-button-drawermenu branch June 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants