Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured dependabot to update packages #294 #295

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

balajik
Copy link
Collaborator

@balajik balajik commented Oct 9, 2023

Summary
Configured dependabot to update the packages by weekly in client, server and e2e packages. Max of 2 PRs will be created in client/server and 1 will be created e2e if there is any new updates available.

Now, I have a configured a bare minimum dependabot setup to update the packages. We can later add or update the configuration in the dependabot.yml file.

Here is the config options for dependabot: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#configuration-options-for-the-dependabotyml-file

Note
As of now, we there is no option to using glob patterns or providing multiple path to the dependabot to pick the package.json in the nested folders. So for now, we have to duplicate the update config for each package folders.

Dependabot issue can be found here: dependabot/dependabot-core#2178 dependabot/dependabot-core#3951

@balajik balajik requested a review from gbowne1 as a code owner October 9, 2023 05:28
@gbowne1 gbowne1 added enhancement New feature or request devops this is a devops related feature or issue or PR labels Oct 9, 2023
@gbowne1 gbowne1 added this to the Testing & Deployment milestone Oct 9, 2023
Copy link
Owner

@gbowne1 gbowne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the documentation and the code in this PR, I believe it shall work as intended to help us keep dependencies up to date automatically.

We can always make minor changes to this if there becomes a problem.

Approving for merge.

@balajik
Copy link
Collaborator Author

balajik commented Oct 9, 2023

After reviewing the documentation and the code in this PR, I believe it shall work as intended to help us keep dependencies up to date automatically.

We can always make minor changes to this if there becomes a problem.

Approving for merge.

@gbowne1 - can you add all the labels to this PR?

@gbowne1 gbowne1 added help wanted Extra attention is needed high-priority needs-review This issue or PR needs review needs-testing This needs testing medium-complexity This issue is medium complexity feature This should be a new feature. hacktoberfest The hacktoberfest label labels Oct 9, 2023
@gbowne1
Copy link
Owner

gbowne1 commented Oct 9, 2023

Not really necessary, but ok, I can. Anyone can add labels, iirc.

@balajik
Copy link
Collaborator Author

balajik commented Oct 9, 2023

Not really necessary, but ok, I can. Anyone can add labels, iirc.

I'm not able to add the labels I think.

Copy link
Collaborator

@pawel975 pawel975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gbowne1
Copy link
Owner

gbowne1 commented Oct 9, 2023

This should help us keep this updated without having to do a lot of extra manual work.

Copy link
Collaborator

@manuel12 manuel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Approving changes.

@manuel12 manuel12 merged commit 02e67f7 into gbowne1:main Oct 10, 2023
@balajik balajik deleted the feature/#294 branch October 10, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops this is a devops related feature or issue or PR enhancement New feature or request feature This should be a new feature. hacktoberfest The hacktoberfest label help wanted Extra attention is needed high-priority medium-complexity This issue is medium complexity needs-review This issue or PR needs review needs-testing This needs testing
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants