Deserializing an array of UuidInterface doesn't work

[christian-kolb]

I'm using an object like the following:

final class ExportMasterDataEntriesQuery implements ProjectionQueryInterface
{
    /**
     * @var UuidInterface[]
     * @psalm-var list<UuidInterface>
     */
    public array $categoryIds;

   ...

And want to deserialize this object from the following JSON:

{
  "categoryIds": [],
  "...": ""
}

The error I get is:

The type of the "categoryIds" attribute for class "App\EventSourcing\Projection\MasterDataExport\Query\ExportMasterDataEntriesQuery" must be one of "Ramsey\Uuid\UuidInterface[]" ("array" given).

My serializer is defined like the following:

$this->serializer = new Serializer(
    [
        new ArrayDenormalizer(),
        new DateTimeNormalizer(),
        new DataUriNormalizer(),
        new UuidNormalizer(),
        new UuidDenormalizer(),
        new ObjectNormalizer(
            $classMetadataFactory,
            null,
            null,
            new PhpDocExtractor()
        ),
        new PropertyNormalizer(),
    ],
    [
        new JsonEncoder(),
    ]
);

Do I have to change something in my serializer setup or is this not supported by this package? If not, would it be possible to add this functionality or could you give me a hint how to add it, then I might try my hand with a pull request.

[gbprod]

Hi !

Could you provide the entire stack trace please ?

[christian-kolb]

Thanks for the quick reply 🙂

Yes, I will boot the project after lunch. In the meantime I've changed it to use strings and will need to change that back to produce the Stack Trace. But I will comment here within the next few hours.

[christian-kolb]

@gbprod Here is the full stack trace as string:

#0 /var/www/project.localhost/current/api/vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php(489): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->validateAndDenormalize() 
#1 /var/www/project.localhost/current/api/vendor/symfony/serializer/Normalizer/AbstractNormalizer.php(496): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->denormalizeParameter() 
#2 /var/www/project.localhost/current/api/vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php(237): Symfony\Component\Serializer\Normalizer\AbstractNormalizer->instantiateObject() 
#3 /var/www/project.localhost/current/api/vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php(335): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->instantiateObject() 
#4 /var/www/project.localhost/current/api/vendor/symfony/serializer/Serializer.php(191): Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer->denormalize() 
#5 /var/www/project.localhost/current/api/vendor/symfony/serializer/Serializer.php(142): Symfony\Component\Serializer\Serializer->denormalize() 
#6 /var/www/project.localhost/current/api/src/EventSourcing/ContractContent/CustomSerializer.php(87): Symfony\Component\Serializer\Serializer->deserialize() 
#7 /var/www/project.localhost/current/api/src/Controller/BaseController.php(153): App\EventSourcing\ContractContent\CustomSerializer->deserialize() 
#8 /var/www/project.localhost/current/api/src/Controller/MasterDataEntry/MasterDataEntryController.php(118): App\Controller\BaseController->getProjectionQueryFromRequest() 
#9 /var/www/project.localhost/current/api/vendor/symfony/http-kernel/HttpKernel.php(158): App\Controller\MasterDataEntry\MasterDataEntryController->exportJSON() 
#10 /var/www/project.localhost/current/api/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw() 
#11 /var/www/project.localhost/current/api/vendor/symfony/http-kernel/Kernel.php(201): Symfony\Component\HttpKernel\HttpKernel->handle() 
#12 /var/www/project.localhost/current/api/public/index.php(25): Symfony\Component\HttpKernel\Kernel->handle() #13 {main}

The CustomSerializer->deserialize() is just a wrapper for:

public function deserialize($data, string $type)
{
    return $this->serializer->deserialize($data, $type, JsonEncoder::FORMAT);
}

The type is the class to which the data should be deserialized.

Let me know if you need more information.

[gbprod]

Thanks, I'm working on a fix.

[gbprod]

I've pushed a fix, can you try again using v1.2.1 and give me a feedback ?

Thanks

[christian-kolb]

Ah you just released 1.2.1, perfect. Yes I will try, but I will only be able to do so tomorrow. I will update you as soon as possible. Thanks for the remarkable turnaround time 🙂

[christian-kolb]

@gbprod Works perfectly, thanks again for the fast response 🙂

[gbprod]

Thanks for the feedback, I'll will improve a little this lib, every feedback or feature requests are welcomes ;)

[christian-kolb]

For now it does everything I need 🙂
But I'm a huge fan of Psalm, maybe integrating it into the library will make it more robust (not that there is a issue I'm aware of)

I will write as soon as I can think of any feature request