Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: defer sqlite insert to avoid highligth blink (#99)" #178

Merged
merged 1 commit into from
May 18, 2024

Conversation

gbprod
Copy link
Owner

@gbprod gbprod commented May 18, 2024

This reverts commit 0dc8e0f.

As it seems to create bugs, I revert until I'll find how to fix it

Ref: #176 #177

@gbprod gbprod merged commit 396ff7e into main May 18, 2024
3 checks passed
@xzbdmw
Copy link

xzbdmw commented May 18, 2024

Hmm, #176 seems to be caused by setting and reading reg too many times to perform a paste, each time it will sync system clipborad so cause the lag

@folke
Copy link
Contributor

folke commented May 18, 2024

I just noticed the delays again and now know why :)

I'll just switch to the shada backend for now.

@folke
Copy link
Contributor

folke commented May 18, 2024

Is there actually any good reason to use the sqlite backend?
I used sqlite because according to the docs it's supposed to be faster, but in reality it seems much slower from my testing.

@gbprod
Copy link
Owner Author

gbprod commented May 22, 2024

I have to investigate for the root cause of those delays.
Sorry about that, I try to fix it asap ;)

@gbprod
Copy link
Owner Author

gbprod commented May 22, 2024

Is there actually any good reason to use the sqlite backend?

For me, it seems faster but I think I have to make some benchmarks with a lot of entries to be sure of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants