JSON import and copy-to-clipboard on click #120
Conversation
This adds support for importing exported gauth JSON files, with * data validation, * multi-file uploads, * account deduplication, and * toastr.js for displaying import status messages.
|
Will try to have a look. Busy days, so perhaps ping me again if no comments by next Monday. |
|
These are nice features and hope you find the time to review and merge. Thank you. |
gbraad
force-pushed
the
master
branch
2 times, most recently
from
39ce510
to
f61ec58
Compare
|
Definitely looks like a necessary improvement @nkrishnaswami -- only nit would be the tab spacing. Pardon me, but have you ever tried using For complete integration in your IDE it varies, but for Thanks for posting the improvement! |
|
Thanks for the pointer, @digitalextremist; I've just run prettier on the file and re-pushed. I'll look at IDE integration next! |
|
Hmm, that diff is really large? Are there any config settings you recommend to match the project style? |
|
Yowza! Yes, that diff is more than you want to change @nkrishnaswami, but that can happen, and might prompt some code cleaning or publishing of code standards. Many projects distill their coding standards and conventions into a |
This comment was marked as off-topic.
This comment was marked as off-topic.
nkrishnaswami
force-pushed
the
master
branch
from
092dae9
to
336bb2b
Compare
|
OK, I've replaced that with a tab-to-space conversion commit. Hopefully this is satisfactory |
|
If toastr is not included, this change will be much smaller already, as this functionality can be easily replaced by a simple statement that gets included/replaced in the page or otherwise visually indicated by a color highlight that disappears. The reason is that this application is still in use by people with less recent browsers on mobile phones. Compatibility is key... |
|
I noticed you added a sourcemap file. This seems unnecessary (but rather not see the toast at all). Also, no update was made to the cache manifest, which means that files are not stored and cause issues for offline use. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi @gbraad,
I found I needed import functionality, so I forked and added it. I also thought it'd be convenient to copy the key on click/tap, since the widget is hard to select/copy from manually. All branches tested manually, so medium to high confidence.
Appreciate any thoughts/feedback/comments!
Thanks, N.