Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON import and copy-to-clipboard on click #120

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nkrishnaswami
Copy link

Hi @gbraad,
I found I needed import functionality, so I forked and added it. I also thought it'd be convenient to copy the key on click/tap, since the widget is hard to select/copy from manually. All branches tested manually, so medium to high confidence.
Appreciate any thoughts/feedback/comments!

Thanks, N.

This adds support for importing exported gauth JSON files, with
* data validation,
* multi-file uploads,
* account deduplication, and
* toastr.js for displaying import status messages.
@gbraad
Copy link
Collaborator

gbraad commented Feb 21, 2022

Will try to have a look. Busy days, so perhaps ping me again if no comments by next Monday.

@bonifacio123
Copy link

These are nice features and hope you find the time to review and merge. Thank you.

@gbraad gbraad force-pushed the master branch 2 times, most recently from 39ce510 to f61ec58 Compare May 1, 2023 06:09
@digitalextremist
Copy link

Definitely looks like a necessary improvement @nkrishnaswami -- only nit would be the tab spacing.

Pardon me, but have you ever tried using [prettier](https://prettier.io/) or similar, with auto-reformat on save?

For complete integration in your IDE it varies, but for SublimeText it uses: https://packagecontrol.io/packages/JsPrettier

Thanks for posting the improvement!

@nkrishnaswami
Copy link
Author

Thanks for the pointer, @digitalextremist; I've just run prettier on the file and re-pushed. I'll look at IDE integration next!

@nkrishnaswami
Copy link
Author

Hmm, that diff is really large? Are there any config settings you recommend to match the project style?

@digitalextremist
Copy link

digitalextremist commented Sep 11, 2023

Yowza! Yes, that diff is more than you want to change @nkrishnaswami, but that can happen, and might prompt some code cleaning or publishing of code standards.

Many projects distill their coding standards and conventions into a prettier config, and release that with the project. Then prettier or a linter, or what have you, uses the project style provided in the repository.

@martinsprinc

This comment was marked as off-topic.

@nkrishnaswami
Copy link
Author

OK, I've replaced that with a tab-to-space conversion commit. Hopefully this is satisfactory

@gbraad
Copy link
Collaborator

gbraad commented Sep 12, 2023

If toastr is not included, this change will be much smaller already, as this functionality can be easily replaced by a simple statement that gets included/replaced in the page or otherwise visually indicated by a color highlight that disappears.

The reason is that this application is still in use by people with less recent browsers on mobile phones. Compatibility is key...

@gbraad
Copy link
Collaborator

gbraad commented Sep 12, 2023

I noticed you added a sourcemap file. This seems unnecessary (but rather not see the toast at all).

Also, no update was made to the cache manifest, which means that files are not stored and cause issues for offline use.

@FrogCoinDev

This comment was marked as off-topic.

@gbraad

This comment was marked as off-topic.

@gbraad-apps gbraad-apps locked as off-topic and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants