Skip to content
This repository has been archived by the owner on Sep 26, 2020. It is now read-only.

bugs and opinions... #25

Open
bttb opened this issue Aug 29, 2019 · 4 comments
Open

bugs and opinions... #25

bttb opened this issue Aug 29, 2019 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Projects

Comments

@bttb
Copy link

bttb commented Aug 29, 2019

Just tried to use this carousel and it looks good to me, just a few opinions and a feature request:

a) I want the photos to be contained, not to be covered, so I need an option to force
background-size: contain
instead of
background-size: cover
in the .carousel-slide css class.

b) My indicators do not appear in the center of the slides, they appear in the right half. In the css styles I see these styles:

left: 50%;
-webkit-transform: translateX(-50%);
transform: translateX(-50%);

If I switch off all of these, they appear where they should be.

image

image

c) I also want to configure margins for indicators. At the moment I see
.carousel-indicators {
bottom: 15px;
margin-right: 15%;
margin-left: 15%;
}

I want to switch off all of these, to have them in a good position.

d) Feature request: I want a carousel with a maximize button, just like in the slider here:
https://www.recordstores.love/56
Here you see a ninja slider with a double arrow in the bottom right corner. If you click that, the whole carousel will maximize (not just one image). I like this feature.

Please contact me if you need an example for a) to c).

@ashwan9904
Copy link

I also have the same problem with b) if you could please post a reply that we can all fix that would be helfpul :)

@gbrlsnchs
Copy link
Owner

@bttb would you mind opening a PR for this specific issue? I would gladly review and merge it. 😺

@gbrlsnchs gbrlsnchs self-assigned this Sep 6, 2019
@gbrlsnchs gbrlsnchs added enhancement New feature or request bug Something isn't working labels Sep 6, 2019
@gbrlsnchs gbrlsnchs added this to To do in Issues via automation Sep 6, 2019
@gabrieltaets
Copy link

About problem (b), do you also have bootstrap installed? Bootstrap also defines class carousel-indicators and they conflict with this lib's definitions.

@bttb
Copy link
Author

bttb commented Oct 23, 2019

Sorry, for not replying earlier, but I was on holiday and am still too busy to investigate more on this. But to answer your last question: Yes, Bootstrap is installed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
Issues
  
To do
Development

No branches or pull requests

4 participants