Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Break up angle_frame_connector Module #30

Open
gbroques opened this issue Apr 7, 2020 · 0 comments
Open

Refactor and Break up angle_frame_connector Module #30

gbroques opened this issue Apr 7, 2020 · 0 comments
Labels

Comments

@gbroques
Copy link
Owner

gbroques commented Apr 7, 2020

The angle_frame_connector.py module is getting quite large at around 500 lines.

It's also used independently from the frame as a stand-alone module from the Angle Frame Connector macro to generate corners for 3d printing.

The angle frame connector has one core component -- the "tri bracket" (better name TBD). We make the tri-bracket three times, and apply the appropriate rotations-and-translations to make the full corner -- taking advantage of the symmetries involved.

Top corners have an additional component -- the "axis side mount" or "tab".

Additionally, the angle frame connector has different features. Namely the ability to have a set-screw mechanism, and the option to apply filleting.

Each one of these components and features could be their own private module in a separate angle_frame_connector package which only exposes a AngleFrameConnector.make interface.

This could greatly help manage the complexity of this part.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant