Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formalize and Document Part Attachment Flow #83

Open
gbroques opened this issue May 15, 2020 · 2 comments
Open

Formalize and Document Part Attachment Flow #83

gbroques opened this issue May 15, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation refactor

Comments

@gbroques
Copy link
Owner

Need a diagram.

  1. Get selection objects
  2. Get attached to and attachee objects from selection objects
  3. Validate them
  4. Call attachment function
  5. Expand attachment kwargs into create_* function

etc.
@gbroques
Copy link
Owner Author

One idea is to formalize the idea of an "attachment function".

Doing so could allow us to make current attachment functions like get_axis_frame_attachment_kwargs less verbose as axis_frame_attachment.

@gbroques gbroques added the documentation Improvements or additions to documentation label May 17, 2020
@gbroques
Copy link
Owner Author

gbroques commented Jun 7, 2020

Some diagrams were made and committed to the document-workbench branch:
https://github.com/gbroques/ose-3d-printer-workbench/tree/document-workbench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbroques