Schema check occurrences (#35)

gbv · Mar 19, 2018 · 5981843 · 5981843
1 parent fec287a
commit 5981843
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/PICA/Schema.pm b/lib/PICA/Schema.pm
@@ -177,6 +177,8 @@ language|https://format.gbv.de/schema/avram/specification>, for instance:
 See L<PICA::Schema::Builder> to automatically construct schemas from PICA
 records.
 
+Schema information can be included in PICA XML with L<PICA::Writer::XML>.
+
 =head1 METHODS
 
 =head2 check( $record [, %options ] )

diff --git a/t/files/schema-tests.yaml b/t/files/schema-tests.yaml
@@ -3,7 +3,7 @@ schemas:
   021A:
     fields:
       021A:
-        required: true
+        required: 1
         subfields:
           a:
             required: 1
@@ -14,11 +14,17 @@ schemas:
   021A-repeatable:
     fields:
       021A:
-        repeatable: true
+        repeatable: 1
   021A-empty-subfields:
     fields:
       021A:
         subfields: {}
+  occurrences:
+    fields:
+      028C/01:
+        required: 1
+      222X:
+        required: 0
 
 records:
   021A: "021A $atitle"
@@ -29,6 +35,8 @@ records:
   021A-unordered-subfields: "021A $dsubtitle$atitle"
   021A-subfield: "021A $atitle$atitle"
   099X: "099X $xy"
+  occurrences: "028C/01 $dEmma$aGoldman\n222X/123 $x23"
+  occurrences-missing: "028C $dEmma$aGoldman"
 
 tests:
 
@@ -106,6 +114,19 @@ tests:
   options:
     ignore_subfield_order: 1
 
+- schema: occurrences
+  record: occurrences-missing
+  result:
+  - tag: 028C
+    message: unknown field 028C
+  - tag: 028C
+    occurrence: '01'
+    message: missing field 028C/01
+    required: 1
+
+- schema: occurrences
+  record: occurrences
+
 # TODO:
 # - check fields in level 1 and level 2 (uniqueness per local copy!)