Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation rules to editors #190

Closed
kkrebs opened this issue Jan 23, 2020 · 3 comments
Closed

add validation rules to editors #190

kkrebs opened this issue Jan 23, 2020 · 3 comments

Comments

@kkrebs
Copy link
Collaborator

kkrebs commented Jan 23, 2020

We need more validation rules to prevent:

  • number twist in date fields: 1986-31-12 instead of 1986-12-31
  • strings in date fields like '-'
  • invalid string as link to other mcrobjects instead of object ID
@kkrebs kkrebs self-assigned this Jan 23, 2020
@annplaksin
Copy link
Collaborator

  • References from expressions to persons (composer & lyricist) should not be mandatory.

  • References from sources to persons (e.g. editor, authors, funders etc., responsible persons for scribe hands, involved persons for events) should not be mandatory

  • Every expression must be referenced in a source via a source component

  • A work needs at least one expression

@sebhofmann
Copy link
Collaborator

see also #160 (comment)

@kkrebs kkrebs added the resolved label Mar 5, 2020
@ja-roh
Copy link

ja-roh commented Mar 16, 2020

I could enter "strange" dates. There was no error message, but the date was not show in the final entry. Thus, I believe some aspects of validation may not be working properly at the moment.

sebhofmann added a commit that referenced this issue Mar 23, 2020
@kkrebs kkrebs closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants