Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabelSearchSuggestionProvider: Fallback to broader concept(s) if no results are found #53

Closed
stefandesu opened this issue Jan 13, 2023 · 1 comment
Labels
feature Additional functionality

Comments

@stefandesu
Copy link
Member

In LabelSearchSuggestionProvider, we could add a fallback to the broader concepts' labels if there are no results. This would improve utility of the suggestions since sometimes the concept itself is too specific for the target vocabulary.

Example: GND "Fußball" is too specific for BK. But its broader term "Ballspiel" occurs as an alternative label for BK 76.14 Sportspiele which would be the right target concept if you wanted to create a mapping.

This could be extended to iterate over all ancestors (for classifications), but for now, I'd only use broader concepts.

@stefandesu stefandesu added the feature Additional functionality label Jan 13, 2023
@stefandesu
Copy link
Member Author

Note that the labels of broader concepts need to be loaded in order for this to work. Currently in Cocoda, since the broader concepts are loaded asynchronously, the first try will lead to no results, but in the second try (by default after 10 seconds) it will use the broader concepts since they'll be loaded. I guess that's good enough for now.

stefandesu added a commit to gbv/cocoda that referenced this issue Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality
Projects
None yet
Development

No branches or pull requests

1 participant