enable custom config file

[kapitainsky]

Sometimes it is useful to use different config files e.g. when different snapshots retentions are needed for different datasets.

I have added "-C, --custom-config </path/to/file>" option

[gbytedev]

Looks good; I'll try and find some time to test this soon. Note to myself: Document this feature in readme & the default config file itself.

[kapitainsky]

Document this feature in readme & the default config file itself.

Both are already included in this PR .

[gbytedev]

Both are already included in this PR .

Nope, with 'default config file' I meant default.zfsbud.conf, with documenting in readme, I meant 'introduction' and 'usage' part of the file. Sorry for not being clear on this.

[gbytedev]

@kapitainsky Looking at the code, this appears to be overwriting the inline --snapshot-prefix argument which should take precedence in my opinion (haven't tested it though). Maybe we should alter and move the initial snapshot_prefix=$(config_get default_snapshot_prefix) to after the input arguments have been read. If you don't have the time, don't worry, I'll grab it soon when I find some. :)

[kapitainsky]

I will look into it. Please note I have been using all these PRs in production for many months now:) And I am very happy with my new functionality

[gbytedev]

Please note I have been using all these PRs in production for many months now:) And I am very happy with my new functionality

I'm happy you are and I am thankful for your contribution, but as the maintainer I need to be thinking in more broader terms and cover more use cases. A setting in a configuration file should not be overwriting an inline argument in my opinion.

[kapitainsky]

Please note I have been using all these PRs in production for many months now:) And I am very happy with my new functionality

I'm happy you are and I am thankful for your contribution, but as the maintainer I need to be thinking in more broader terms and cover more use cases. A setting in a configuration file should not be overwriting an inline argument in my opinion.

Agree. Good catch. Fixed