Skip to content

Commit

Permalink
Do not delete a ShellCmd remote job's PID file until
Browse files Browse the repository at this point in the history
`ShellcmdLrms.free()` is called.

Removal of remote job's PID file should only be done in the
`ShellcmdLrms.free()` method, and *not* at other stages of the job's
lifecycle.
  • Loading branch information
riccardomurri committed Aug 14, 2017
1 parent 0c4ba9b commit 48a9c97
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions gc3libs/backends/shellcmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,6 @@ def cancel_job(self, app):
else:
# ignore
pass
self._delete_job_info_file(root_pid)

def _grace_time(self, wait):
if wait:
Expand Down Expand Up @@ -1656,8 +1655,6 @@ def _cleanup_terminating_task(self, app, pid, termstatus=None):
.format(wrapper_filename, app, err))
log.warning("%s -- Termination status and resource utilization fields will not be set.", msg)
raise gc3libs.exceptions.InvalidValue(msg)
finally:
self._delete_job_info_file(pid)

def _parse_wrapper_output(self, wrapper_file):
"""
Expand Down

0 comments on commit 48a9c97

Please sign in to comment.