Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCDiscreetNotificationView visible during flip transition of iPhone only utility app running on iPad #6

Merged
merged 1 commit into from
Jan 6, 2012

Conversation

bradsokol
Copy link
Contributor

Guillaume,

I've had GCDiscreetNotificationView integrated in to my app for a little while and it works very well. Thanks for your contribution.

I did notice a small bug that occurs in the following situation:

  • GCDiscreetNotificationView added to the main view of a utility-style app (i.e. one that flips like the built in Weather and Stocks apps).
  • GCDiscreetNotificationView is currently hidden
  • App is an iPhone-only app running on the iPad in the iPhone "emulation" view

In this situation, the GCDiscreetNotificationView will be visible during the flip to and from the main view.

This patch corrects this problem.

Let me know if you have questions.

Thanks again,
Brad

…he main view in a utility-style app running in the iPhone window on an iPad.
@gcamp
Copy link
Owner

gcamp commented Jan 6, 2012

Thanks!

@gcamp gcamp closed this Jan 6, 2012
gcamp added a commit that referenced this pull request Jan 6, 2012
GCDiscreetNotificationView visible during flip transition of iPhone only utility app running on iPad
@gcamp gcamp merged commit 3075ef2 into gcamp:master Jan 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants