Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop phantom fields? #806

Closed
gcanti opened this issue Apr 1, 2019 · 2 comments
Closed

Drop phantom fields? #806

gcanti opened this issue Apr 1, 2019 · 2 comments
Milestone

Comments

@gcanti
Copy link
Owner

gcanti commented Apr 1, 2019

@sledorze @raveclassic the internals of fp-ts don't rely on the presence on those phantom fields anymore (_A, _L, etc...), do we want to try to remove them and ship version 1.16 in future releases? This would allow to test this change in the wild (and overall it's quite easy to revert in case of issues)

@raveclassic
Copy link
Collaborator

Yeah, let's try to drop them. However I won't be able to test the changes in production env/projects soon.

@sledorze
Copy link
Collaborator

sledorze commented Apr 1, 2019

I can try on our code base this week.
It will surely breaks some stuff.
:)

@gcanti gcanti changed the title Drop phantom fields in 1.16? Drop phantom fields? Apr 9, 2019
@gcanti gcanti added this to the 2.0 milestone Apr 12, 2019
@gcanti gcanti closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants