Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Apply/ap): make total overloads F: 0,1,2,2C,3,3C,4 to G: 1,2,2C,3,3C,4 #1721

Merged
merged 41 commits into from Aug 22, 2022
Merged

feat(Apply/ap): make total overloads F: 0,1,2,2C,3,3C,4 to G: 1,2,2C,3,3C,4 #1721

merged 41 commits into from Aug 22, 2022

Conversation

waynevanson
Copy link
Contributor

@waynevanson waynevanson commented Jun 11, 2022

There are some overloads missing that I needed in in my projects, and figured we may as well add all the overloads for the functions.

Questions:

  • What is preferred, A => B or A1 => A2? I prefer the latter because there's no good standard on letters after Q.
  • Could we do A1 instead of A? I've been using vim search and replace and it's much easier when they all have numbers.

@waynevanson waynevanson changed the title feat: add applicable overloads feat(Apply/ap): make total overloads F: 0,1,2,2C,3,3C,4 to G: 1,2,2C,3,3C,4 Jun 12, 2022
@waynevanson waynevanson marked this pull request as ready for review June 12, 2022 01:17
@waynevanson
Copy link
Contributor Author

@gcanti Could I get a rerun on this one?

@waynevanson
Copy link
Contributor Author

@gcanti Please review when you get the chance, it ran.

@gcanti
Copy link
Owner

gcanti commented Aug 5, 2022

What is preferred, A => B or A1 => A2?

For consistency with all the other signatures I'd keep A => B

@waynevanson
Copy link
Contributor Author

What is preferred, A => B or A1 => A2?

For consistency with all the other signatures I'd keep A => B

@gcanti I've used the Functor module as the reference for the syntax.

@gcanti gcanti merged commit e140444 into gcanti:master Aug 22, 2022
@waynevanson waynevanson deleted the feat.overloads branch September 2, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants