Cache all strings #700
Closed
Cache all strings #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2023 02:16
|
Re-opening this one, it's not the most fp implementation, but I'm open to feedback there :) |
|
Ha! closing again, discussed internally with my team, looks to be user error that these are being created over and over again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-using codecs becomes a really memory costly operation, even lightly CPU intensive too - creating codec strings over and over again that can't be de-duped or reused. This is an attempt to cache all strings used for "names". Very open to feedback here.
Before submitting a pull request, please make sure the following is done:
master.npm installin the repository root.npm test).Note. If you find a typo in the documentation, make sure to modify the corresponding source (docs are generated).