Android timepicker always open the current time #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaromb
requested changes
Jun 9, 2017
| @@ -0,0 +1,6 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
Please remove all the .idea/ files.
| const now = new Date(); | ||
| const isDate = locals.value && locals.value instanceof Date; | ||
| let setTime = { | ||
| hour: (isDate) ? locals.value.getHours() : now.getHours(), |
There was a problem hiding this comment.
Can you format your code to 2 space tabs?
alvaromb
approved these changes
Jun 9, 2017
|
@gcanti seems good to merge for me. Also, @francescjimenez would like to help us maintain the library. |
|
@francescjimenez could you please squash the commits? |
|
nice thanks! ;) |
|
I'm having this problem guys. At which version this has been fixed? |
|
In the last version is solved |
|
Which is? I'm using 0.6.9. |
|
Sorry, it was my mistake. Solved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behaviour
When edit time, android time picker must show the time based on the time of the data
Actual behaviour
Android date picker always show the current time
Solution
Change file datepicker.android.js