Skip to content
This repository has been archived by the owner on Mar 20, 2019. It is now read-only.

Commit

Permalink
Merge pull request #122 from gcarq/feature/63
Browse files Browse the repository at this point in the history
Update to 63.0.3239.84
  • Loading branch information
gcarq committed Dec 11, 2017
2 parents 2eb5177 + 6fa3b1f commit 3688ea6
Show file tree
Hide file tree
Showing 23 changed files with 431 additions and 1,073 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ inox-*.tar*
test*
chromium-freetype2/
*.log
chromium-*.txt
279 changes: 95 additions & 184 deletions 0001-fix-building-without-safebrowsing.patch

Large diffs are not rendered by default.

23 changes: 11 additions & 12 deletions 0005-disable-default-extensions.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -434,11 +434,6 @@ void ComponentLoader::AddWebStoreApp() {
@@ -441,11 +441,6 @@ void ComponentLoader::AddWebStoreApp() {
if (!IsNormalSession())
return;
#endif
Expand All @@ -12,7 +12,7 @@
}

scoped_refptr<const Extension> ComponentLoader::CreateExtension(
@@ -493,11 +488,6 @@ void ComponentLoader::AddDefaultComponen
@@ -500,11 +495,6 @@ void ComponentLoader::AddDefaultComponen
Add(IDR_BOOKMARKS_MANIFEST,
base::FilePath(FILE_PATH_LITERAL("bookmark_manager")));
}
Expand All @@ -24,7 +24,7 @@
#endif // defined(OS_CHROMEOS)

if (!skip_session_components) {
@@ -575,13 +565,6 @@ void ComponentLoader::AddDefaultComponen
@@ -582,13 +572,6 @@ void ComponentLoader::AddDefaultComponen
AddHotwordAudioVerificationApp();
AddHotwordHelperExtension();
AddImageLoaderExtension();
Expand All @@ -40,20 +40,19 @@
#if defined(OS_CHROMEOS)
--- a/chrome/browser/extensions/external_component_loader.cc
+++ b/chrome/browser/extensions/external_component_loader.cc
@@ -38,13 +38,6 @@ ExternalComponentLoader::~ExternalCompon
@@ -34,12 +34,6 @@ ExternalComponentLoader::~ExternalCompon

void ExternalComponentLoader::StartLoading() {
prefs_.reset(new base::DictionaryValue());
auto prefs = std::make_unique<base::DictionaryValue>();
-#if defined(GOOGLE_CHROME_BUILD)
- AddExternalExtension(extension_misc::kInAppPaymentsSupportAppId);
- AddExternalExtension(extension_misc::kInAppPaymentsSupportAppId, prefs.get());
-#endif // defined(GOOGLE_CHROME_BUILD)
-
- if (HotwordServiceFactory::IsHotwordAllowed(profile_))
- AddExternalExtension(extension_misc::kHotwordSharedModuleId);
-
- AddExternalExtension(extension_misc::kHotwordSharedModuleId, prefs.get());
#if defined(OS_CHROMEOS)
{
base::CommandLine* const command_line =
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -580,6 +580,7 @@ void WebstoreInstaller::DownloadNextPend
Expand All @@ -72,15 +71,15 @@
}

// http://crbug.com/165634
@@ -749,6 +751,7 @@ void WebstoreInstaller::UpdateDownloadPr
@@ -750,6 +752,7 @@ void WebstoreInstaller::UpdateDownloadPr
}

void WebstoreInstaller::StartCrxInstaller(const DownloadItem& download) {
+#if 0
DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!crx_installer_.get());

@@ -771,6 +774,7 @@ void WebstoreInstaller::StartCrxInstalle
@@ -772,6 +775,7 @@ void WebstoreInstaller::StartCrxInstalle
crx_installer_->set_allow_silent_install(true);

crx_installer_->InstallCrx(download.GetFullPath());
Expand All @@ -90,7 +89,7 @@
void WebstoreInstaller::ReportFailure(const std::string& error,
--- a/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
+++ b/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
@@ -30,8 +30,6 @@ namespace extensions {
@@ -26,8 +26,6 @@ namespace extensions {

bool IsComponentExtensionWhitelisted(const std::string& extension_id) {
const char* const kAllowed[] = {
Expand Down
43 changes: 8 additions & 35 deletions 0006-modify-default-prefs.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -832,7 +832,7 @@ ChromeContentBrowserClient::~ChromeConte
@@ -866,7 +866,7 @@ void ChromeContentBrowserClient::Registe
void ChromeContentBrowserClient::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(prefs::kDisable3DAPIs, false);
Expand Down Expand Up @@ -82,12 +82,12 @@

--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -276,7 +276,7 @@ void AutofillManager::RegisterProfilePre
@@ -281,7 +281,7 @@ void AutofillManager::RegisterProfilePre
registry->RegisterIntegerPref(
prefs::kAutofillCreditCardSigninPromoImpressionCount, 0);
registry->RegisterBooleanPref(
prefs::kAutofillEnabled,
- true,
+ false,
- prefs::kAutofillEnabled, true,
+ prefs::kAutofillEnabled, false,
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
registry->RegisterBooleanPref(
prefs::kAutofillProfileUseDatesFixed, false,
Expand All @@ -104,7 +104,7 @@
</dialog>
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -623,7 +623,7 @@ void IOThread::RegisterPrefs(PrefRegistr
@@ -610,7 +610,7 @@ void IOThread::RegisterPrefs(PrefRegistr
std::string());
registry->RegisterBooleanPref(prefs::kEnableReferrers, true);
data_reduction_proxy::RegisterPrefs(registry);
Expand Down Expand Up @@ -154,15 +154,6 @@
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
#if defined(OS_ANDROID)
registry->RegisterStringPref(
@@ -152,7 +152,7 @@ void Profile::RegisterProfilePrefs(user_
// This pref is intentionally outside the above #if. That flag corresponds
// to the Notifier extension and does not gate the launcher page.
// TODO(skare): Remove or rename ENABLE_GOOGLE_NOW: http://crbug.com/459827.
- registry->RegisterBooleanPref(prefs::kGoogleNowLauncherEnabled, true);
+ registry->RegisterBooleanPref(prefs::kGoogleNowLauncherEnabled, false);
registry->RegisterBooleanPref(prefs::kDisableExtensions, false);
#if BUILDFLAG(ENABLE_EXTENSIONS)
registry->RegisterBooleanPref(extensions::pref_names::kAlertsInitialized,
--- a/chrome/service/cloud_print/connector_settings.cc
+++ b/chrome/service/cloud_print/connector_settings.cc
@@ -60,7 +60,7 @@ void ConnectorSettings::InitFrom(Service
Expand Down Expand Up @@ -206,7 +197,7 @@
// functionality that are only available in chrome://extensions/ but which
--- a/components/safe_browsing/common/safe_browsing_prefs.cc
+++ b/components/safe_browsing/common/safe_browsing_prefs.cc
@@ -372,9 +372,9 @@ void RegisterProfilePrefs(PrefRegistrySi
@@ -370,9 +370,9 @@ void RegisterProfilePrefs(PrefRegistrySi
registry->RegisterBooleanPref(
prefs::kSafeBrowsingSawInterstitialScoutReporting, false);
registry->RegisterBooleanPref(
Expand All @@ -218,27 +209,9 @@
user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
registry->RegisterBooleanPref(prefs::kSafeBrowsingProceedAnywayDisabled,
false);
--- a/components/safe_browsing/features.cc
+++ b/components/safe_browsing/features.cc
@@ -43,13 +43,13 @@ const base::Feature kParallelUrlCheck{"S
base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kPasswordFieldOnFocusPinging{
- "PasswordFieldOnFocusPinging", base::FEATURE_ENABLED_BY_DEFAULT};
+ "PasswordFieldOnFocusPinging", base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kPasswordProtectionInterstitial{
"PasswordProtectionInterstitial", base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kProtectedPasswordEntryPinging{
- "ProtectedPasswordEntryPinging", base::FEATURE_ENABLED_BY_DEFAULT};
+ "ProtectedPasswordEntryPinging", base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kThreatDomDetailsTagAndAttributeFeature{
"ThreatDomDetailsTagAttributes", base::FEATURE_DISABLED_BY_DEFAULT};
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -199,10 +199,10 @@ PasswordFormManager* FindMatchedManager(
@@ -207,10 +207,10 @@ PasswordFormManager* FindMatchedManager(
void PasswordManager::RegisterProfilePrefs(
user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(
Expand Down
4 changes: 2 additions & 2 deletions 0008-restore-classic-ntp.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/chrome/browser/search/search.cc
+++ b/chrome/browser/search/search.cc
@@ -217,17 +217,7 @@ struct NewTabURLDetails {
@@ -170,17 +170,7 @@ struct NewTabURLDetails {
return NewTabURLDetails(local_url, NEW_TAB_URL_VALID);

NewTabURLState state = IsValidNewTabURL(profile, search_provider_url);
Expand All @@ -21,7 +21,7 @@
GURL url;
--- a/components/ntp_snippets/features.cc
+++ b/components/ntp_snippets/features.cc
@@ -38,16 +38,16 @@ const base::Feature* const kAllFeatures[] = {
@@ -38,16 +38,16 @@ const base::Feature* const kAllFeatures[
nullptr};

const base::Feature kArticleSuggestionsFeature{
Expand Down
2 changes: 1 addition & 1 deletion 0009-disable-google-ipv6-probes.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/net/dns/host_resolver_impl.cc
+++ b/net/dns/host_resolver_impl.cc
@@ -107,10 +107,10 @@ const unsigned kMinimumTTLSeconds = kCac
@@ -108,10 +108,10 @@ const unsigned kMinimumTTLSeconds = kCac
// cached.
const int kIPv6ProbePeriodMs = 1000;

Expand Down
8 changes: 4 additions & 4 deletions 0012-branding.patch
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
</message>
</if>
<if expr="chromeos">
@@ -296,7 +296,7 @@ If you update this file, be sure also to
@@ -278,7 +278,7 @@ If you update this file, be sure also to
</if>
<if expr="not chromeos">
<message name="IDS_OPTIONS_RELAUNCH_REQUIRED" desc="The message displayed for an option that requires a relaunch to take effect. This appears in a message box if an option is changed that requires a relaunch.">
Expand All @@ -64,7 +64,7 @@
</message>
</if>
<if expr="chromeos">
@@ -637,7 +637,7 @@ Chromium is unable to recover your setti
@@ -608,7 +608,7 @@ Chromium is unable to recover your setti

<if expr="use_titlecase and not chromeos">
<message name="IDS_ABOUT" desc="In Title Case: The text label of the About Chrome menu item">
Expand All @@ -73,7 +73,7 @@
</message>
<message name="IDS_UPDATE_NOW" desc="In Title Case: The text label of the Update Chrome Now menu item">
Update &amp;Chromium
@@ -645,7 +645,7 @@ Chromium is unable to recover your setti
@@ -616,7 +616,7 @@ Chromium is unable to recover your setti
</if>
<if expr="not use_titlecase and not chromeos">
<message name="IDS_ABOUT" desc="The text label of the About Chrome menu item">
Expand All @@ -82,7 +82,7 @@
</message>
<message name="IDS_UPDATE_NOW" desc="The text label of the Update Chrome Now menu item">
Update &amp;Chromium
@@ -662,7 +662,7 @@ Chromium is unable to recover your setti
@@ -633,7 +633,7 @@ Chromium is unable to recover your setti

<if expr="is_macosx">
<message name="IDS_APP_MENU_PRODUCT_NAME" desc="The application's short name, used for the Mac's application menu, activity monitor, etc. This should be less than 16 characters. Example: Chrome, not Google Chrome.">
Expand Down
18 changes: 11 additions & 7 deletions 0014-disable-translation-lang-fetch.patch
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
request_pending_ = true;
--- a/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
+++ b/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
@@ -151,7 +151,6 @@ void SpellcheckHunspellDictionary::Retry
@@ -155,7 +155,6 @@ void SpellcheckHunspellDictionary::Retry
return;
}
request_context_getter_ = request_context_getter;
- DownloadDictionary(GetDictionaryURL());
}

bool SpellcheckHunspellDictionary::IsReady() const {
@@ -368,9 +367,6 @@ void SpellcheckHunspellDictionary::Initi
@@ -375,9 +374,6 @@ void SpellcheckHunspellDictionary::Initi
}

if (request_context_getter_) {
Expand All @@ -31,22 +31,26 @@
}
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -136,11 +136,9 @@ TranslateRankerImpl::TranslateRankerImpl
@@ -148,14 +148,10 @@ TranslateRankerImpl::TranslateRankerImpl
ukm::UkmRecorder* ukm_recorder)
: ukm_recorder_(ukm_recorder),
is_logging_enabled_(false),
- is_query_enabled_(base::FeatureList::IsEnabled(kTranslateRankerQuery)),
- is_enforcement_enabled_(
- base::FeatureList::IsEnabled(kTranslateRankerEnforcement)),
- is_decision_override_enabled_(base::FeatureList::IsEnabled(
- translate::kTranslateRankerDecisionOverride)),
- is_auto_blacklist_override_enabled_(base::FeatureList::IsEnabled(
- translate::kTranslateRankerAutoBlacklistOverride)),
- is_previous_language_matches_override_enabled_(
- base::FeatureList::IsEnabled(
- translate::kTranslateRankerPreviousLanguageMatchesOverride)),
+ is_query_enabled_(false),
+ is_enforcement_enabled_(false),
+ is_decision_override_enabled_(false),
+ is_auto_blacklist_override_enabled_(false),
+ is_previous_language_matches_override_enabled_(false),
weak_ptr_factory_(this) {
if (is_query_enabled_ || is_enforcement_enabled_) {
model_loader_ = base::MakeUnique<machine_intelligence::RankerModelLoader>(
@@ -207,6 +205,8 @@ bool TranslateRankerImpl::ShouldOfferTra
@@ -229,6 +225,8 @@ bool TranslateRankerImpl::ShouldOfferTra
// (or become False).
const bool kDefaultResponse = true;

Expand Down
2 changes: 1 addition & 1 deletion 0017-disable-new-avatar-menu.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/components/signin/core/browser/signin_manager.cc
+++ b/components/signin/core/browser/signin_manager.cc
@@ -270,7 +270,7 @@ void SigninManager::OnGoogleServicesUser
@@ -289,7 +289,7 @@ void SigninManager::OnGoogleServicesUser
}

bool SigninManager::IsSigninAllowed() const {
Expand Down
73 changes: 9 additions & 64 deletions 0018-disable-first-run-behaviour.patch
Original file line number Diff line number Diff line change
@@ -1,66 +1,11 @@
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -1105,8 +1105,6 @@ void StartupBrowserCreatorImpl::AddStart
// Replace magic names for the actual urls.
if (it->host() == "new_tab_page") {
startup_urls->push_back(GURL(chrome::kChromeUINewTabURL));
- } else if (it->host() == "welcome_page") {
- startup_urls->push_back(internals::GetWelcomePageURL());
} else {
startup_urls->push_back(*it);
}
@@ -1121,10 +1119,6 @@ void StartupBrowserCreatorImpl::AddStart
if (startup_urls->empty()) {
AddSpecialURLs(startup_urls);
startup_urls->push_back(GURL(chrome::kChromeUINewTabURL));
-
- // Special case the FIRST_RUN_LAST_TAB case of the welcome page.
- if (welcome_run_type_ == WelcomeRunType::FIRST_RUN_LAST_TAB)
- startup_urls->push_back(internals::GetWelcomePageURL());
}

if (signin::ShouldShowPromoAtStartup(profile_, is_first_run_)) {
@@ -1160,10 +1154,6 @@ void StartupBrowserCreatorImpl::AddStart

void StartupBrowserCreatorImpl::AddSpecialURLs(
std::vector<GURL>* url_list) const {
- // Optionally include the welcome page.
- if (welcome_run_type_ == WelcomeRunType::FIRST_TAB)
- url_list->insert(url_list->begin(), internals::GetWelcomePageURL());
-
// If this Profile is marked for a reset prompt, ensure the reset
// settings dialog appears.
if (ProfileHasResetTrigger()) {
--- a/chrome/browser/ui/startup/startup_tab_provider.cc
+++ b/chrome/browser/ui/startup/startup_tab_provider.cc
@@ -189,12 +189,6 @@ bool StartupTabProviderImpl::ShouldShowW
StartupTabs StartupTabProviderImpl::GetStandardOnboardingTabsForState(
const StandardOnboardingTabsParams& params) {
StartupTabs tabs;
- if (CanShowWelcome(params.is_signin_allowed, params.is_supervised_user) &&
- ShouldShowWelcomeForOnboarding(params.has_seen_welcome_page,
- params.is_signed_in,
- params.is_signin_in_progress)) {
- tabs.emplace_back(GetWelcomePageUrl(!params.is_first_run), false);
- }
return tabs;
}

@@ -217,15 +211,8 @@ bool StartupTabProviderImpl::ShouldShowW
StartupTabs StartupTabProviderImpl::GetWin10OnboardingTabsForState(
const StandardOnboardingTabsParams& standard_params,
const Win10OnboardingTabsParams& win10_params) {
- if (CanShowWin10Welcome(win10_params.set_default_browser_allowed,
- standard_params.is_supervised_user) &&
- ShouldShowWin10WelcomeForOnboarding(win10_params.has_seen_win10_promo,
- win10_params.is_default_browser)) {
- return {StartupTab(GetWin10WelcomePageUrl(!standard_params.is_first_run),
- false)};
- }
-
- return GetStandardOnboardingTabsForState(standard_params);
+ StartupTabs tabs;
+ return tabs;
}
#endif

@@ -58,7 +58,7 @@ bool ProfileHasOtherTabbedBrowser(Profil

StartupTabs StartupTabProviderImpl::GetOnboardingTabs(Profile* profile) const {
// Onboarding content has not been launched on Chrome OS.
-#if defined(OS_CHROMEOS)
+#if 1
return StartupTabs();
#else
if (!profile)
Loading

0 comments on commit 3688ea6

Please sign in to comment.