fix: se implementa nuevamente reproductor de video con contenedor #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us modificaciones
davisLjr
requested review from
alan199912,
Jesus1397,
lautarorodriguez96,
matilope and
victorianastasi
alan199912
suggested changes
Feb 27, 2023
| @@ -4,13 +4,37 @@ import './Audio.stories.scss'; | |||
|
|
|||
| // Addons | |||
| import { withA11y } from '@storybook/addon-a11y'; | |||
| import { Video, VideoYt } from '.'; | |||
|
|
|||
| // Configuración general del componente | |||
| export default { | |||
| title: 'Componentes|Audio', | |||
There was a problem hiding this comment.
La idea era que la carpeta principal sea Reproductor y despues subcarpetas con audio y video
matilope
reviewed
Mar 2, 2023
| /> | ||
| </div> | ||
| <div className="card-body"> | ||
| <div className="mb-2"> |
There was a problem hiding this comment.
El margen debería ser de margin-bottom: 0.75rem; en desktop y 0.5rem en mobile.
En mi opinión por la diferencia vale la pena poner el margen correcto.
matilope
reviewed
Mar 2, 2023
| <span className="badge badge-danger">Etiqueta</span> | ||
| </div> | ||
| <h4 className="card-title">Titular de la tarjeta con dos líneas de ejemplo</h4> | ||
| <p className="card-text"> |
There was a problem hiding this comment.
El margen debería ser de margin-bottom: 0.75rem; en desktop y 0.5rem en mobile.
matilope
reviewed
Mar 2, 2023
| z-index: 2; | ||
| } | ||
|
|
||
| .main-iframe{ |
There was a problem hiding this comment.
Mandale un format document con prettier.
matilope
reviewed
Mar 2, 2023
|
|
||
| // Configuración general del componente | ||
| export default { | ||
| title: 'Componentes|Audio', | ||
| decorators: [withA11y] | ||
| }; | ||
|
|
||
| export const VideoLocal = (): JSX.Element => { |
There was a problem hiding this comment.
Si se quiere que se ordene alfabéticamente las historias, habría que poner las constantes en orden alfabético, no se ordenan con la implementación del Storybook 1.46.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esta es una propuesta para el componente, esta abierto a mejoras de rendimiento, estilos, codigo y accesibilidad.
Enlace a figma:
https://www.figma.com/file/ToGlPBzfp1gKDmaCwKWtXS/UI-KIT---Obelisco?node-id=1141%3A14083&t=M0RtjuyCsM6RxM43-0