mirrored from git://gcc.gnu.org/git/gcc.git
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RISC-V: Fix attributes bug configuration of ternary instructions
This patch fixes the following FAILs: Running target riscv-sim/-march=rv64gcv/-mabi=lp64d/-mcmodel=medlow/--param=riscv-autovec-preference=fixed-vlmax FAIL: gcc.c-torture/execute/pr68532.c -O0 execution test FAIL: gcc.c-torture/execute/pr68532.c -O1 execution test FAIL: gcc.c-torture/execute/pr68532.c -O2 execution test FAIL: gcc.c-torture/execute/pr68532.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test FAIL: gcc.c-torture/execute/pr68532.c -O3 -g execution test FAIL: gcc.c-torture/execute/pr68532.c -Os execution test FAIL: gcc.c-torture/execute/pr68532.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test Running target riscv-sim/-march=rv64gcv/-mabi=lp64d/-mcmodel=medlow/--param=riscv-autovec-lmul=m2/--param=riscv-autovec-preference=fixed-vlmax FAIL: gcc.dg/vect/pr60196-1.c execution test FAIL: gcc.dg/vect/pr60196-1.c -flto -ffat-lto-objects execution test Running target riscv-sim/-march=rv64gcv/-mabi=lp64d/-mcmodel=medlow/--param=riscv-autovec-preference=fixed-vlmax FAIL: gcc.dg/vect/pr60196-1.c execution test FAIL: gcc.dg/vect/pr60196-1.c -flto -ffat-lto-objects execution test Running target riscv-sim/-march=rv64gcv_zvl256b/-mabi=lp64d/-mcmodel=medlow/--param=riscv-autovec-preference=fixed-vlmax FAIL: gcc.dg/vect/pr60196-1.c execution test FAIL: gcc.dg/vect/pr60196-1.c -flto -ffat-lto-objects execution test The root cause is attributes of ternary intructions are incorrect which cause AVL prop PASS and VSETVL PASS behave incorrectly. Tested no regression and committed. PR target/113393 gcc/ChangeLog: * config/riscv/vector.md: Fix ternary attributes. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/pr113393-1.c: New test. * gcc.target/riscv/rvv/autovec/pr113393-2.c: New test. * gcc.target/riscv/rvv/autovec/pr113393-3.c: New test.
- Loading branch information
1 parent
65678b2
commit 0627d1f
Showing
4 changed files
with
79 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* { dg-do run } */ | ||
| /* { dg-options "-O3 --param=riscv-autovec-preference=fixed-vlmax" } */ | ||
| /* { dg-require-effective-target riscv_v } */ | ||
|
|
||
| #define SIZE 128 | ||
| unsigned short _Alignas (16) in[SIZE]; | ||
|
|
||
| __attribute__ ((noinline)) int | ||
| test (unsigned short sum, unsigned short *in, int x) | ||
| { | ||
| for (int j = 0; j < SIZE; j += 8) | ||
| sum += in[j] * x; | ||
| return sum; | ||
| } | ||
|
|
||
| int | ||
| main () | ||
| { | ||
| for (int i = 0; i < SIZE; i++) | ||
| in[i] = i; | ||
| if (test (0, in, 1) != 960) | ||
| __builtin_abort (); | ||
| return 0; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* { dg-do run } */ | ||
| /* { dg-options "-O3 --param=riscv-autovec-preference=fixed-vlmax --param=riscv-autovec-lmul=m2" } */ | ||
| /* { dg-require-effective-target riscv_v } */ | ||
|
|
||
| __attribute__((noinline, noclone)) static int | ||
| bar (const short *a, int len) | ||
| { | ||
| int x; | ||
| int x1 = 0; | ||
|
|
||
| for (x = 0; x < len; x++) | ||
| x1 += x * a[x]; | ||
| return x1; | ||
| } | ||
|
|
||
| __attribute__((noinline, noclone)) void | ||
| foo (void) | ||
| { | ||
| short stuff[9] = {1, 1, 1, 1, 1, 1, 1, 1, 1 }; | ||
| if (bar (stuff, 9) != 36) | ||
| __builtin_abort (); | ||
| } | ||
|
|
||
| int | ||
| main () | ||
| { | ||
| foo (); | ||
| return 0; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /* { dg-do run } */ | ||
| /* { dg-options "-O3 --param=riscv-autovec-preference=fixed-vlmax" } */ | ||
| /* { dg-require-effective-target riscv_v } */ | ||
|
|
||
| #include "pr113393-2.c" |