Skip to content

Commit

Permalink
Revert: "Enable prange support." [PR114985]
Browse files Browse the repository at this point in the history
This reverts commit 36e8779 until the IPA
pass is fixed with regards to POINTER = POINTER <RELOP> POINTER.
  • Loading branch information
aldyh committed May 9, 2024
1 parent f2449b5 commit d7bb8ea
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 18 deletions.
4 changes: 2 additions & 2 deletions gcc/gimple-range-cache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@ sbr_sparse_bitmap::sbr_sparse_bitmap (tree t, vrange_allocator *allocator,
// Pre-cache zero and non-zero values for pointers.
if (POINTER_TYPE_P (t))
{
prange nonzero;
int_range<2> nonzero;
nonzero.set_nonzero (t);
m_range[1] = m_range_allocator->clone (nonzero);
prange zero;
int_range<2> zero;
zero.set_zero (t);
m_range[2] = m_range_allocator->clone (zero);
}
Expand Down
4 changes: 2 additions & 2 deletions gcc/gimple-range-fold.cc
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ fold_using_range::fold_stmt (vrange &r, gimple *s, fur_source &src, tree name)
// Process addresses.
if (gimple_code (s) == GIMPLE_ASSIGN
&& gimple_assign_rhs_code (s) == ADDR_EXPR)
return range_of_address (as_a <prange> (r), s, src);
return range_of_address (as_a <irange> (r), s, src);

gimple_range_op_handler handler (s);
if (handler)
Expand Down Expand Up @@ -757,7 +757,7 @@ fold_using_range::range_of_range_op (vrange &r,
// If a range cannot be calculated, set it to VARYING and return true.

bool
fold_using_range::range_of_address (prange &r, gimple *stmt, fur_source &src)
fold_using_range::range_of_address (irange &r, gimple *stmt, fur_source &src)
{
gcc_checking_assert (gimple_code (stmt) == GIMPLE_ASSIGN);
gcc_checking_assert (gimple_assign_rhs_code (stmt) == ADDR_EXPR);
Expand Down
2 changes: 1 addition & 1 deletion gcc/gimple-range-fold.h
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class fold_using_range
fur_source &src);
bool range_of_call (vrange &r, gcall *call, fur_source &src);
bool range_of_cond_expr (vrange &r, gassign* cond, fur_source &src);
bool range_of_address (prange &r, gimple *s, fur_source &src);
bool range_of_address (irange &r, gimple *s, fur_source &src);
bool range_of_phi (vrange &r, gphi *phi, fur_source &src);
void range_of_ssa_name_with_loop_info (vrange &, tree, class loop *, gphi *,
fur_source &src);
Expand Down
2 changes: 1 addition & 1 deletion gcc/gimple-range-infer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ gimple_infer_range::add_nonzero (tree name)
{
if (!gimple_range_ssa_p (name))
return;
prange nz;
int_range<2> nz;
nz.set_nonzero (TREE_TYPE (name));
add_range (name, nz);
}
Expand Down
2 changes: 1 addition & 1 deletion gcc/gimple-range-op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,7 @@ class cfn_strlen : public range_operator
{
public:
using range_operator::fold_range;
virtual bool fold_range (irange &r, tree type, const prange &,
virtual bool fold_range (irange &r, tree type, const irange &,
const irange &, relation_trio) const
{
wide_int max = irange_val_max (ptrdiff_type_node);
Expand Down
2 changes: 1 addition & 1 deletion gcc/gimple-range-path.cc
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ path_range_query::compute_ranges_in_block (basic_block bb)
void
path_range_query::adjust_for_non_null_uses (basic_block bb)
{
prange r;
int_range_max r;
bitmap_iterator bi;
unsigned i;

Expand Down
2 changes: 1 addition & 1 deletion gcc/gimple-ssa-warn-access.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4213,7 +4213,7 @@ pass_waccess::check_pointer_uses (gimple *stmt, tree ptr,
where the realloc call is known to have failed are valid.
Ignore pointers that nothing is known about. Those could
have escaped along with their nullness. */
prange vr;
value_range vr;
if (m_ptr_qry.rvals->range_of_expr (vr, realloc_lhs, use_stmt))
{
if (vr.zero_p ())
Expand Down
2 changes: 1 addition & 1 deletion gcc/ipa-cp.h
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ bool values_equal_for_ipcp_p (tree x, tree y);
static inline bool
ipa_supports_p (tree type)
{
return irange::supports_p (type) || prange::supports_p (type);
return irange::supports_p (type);
}

#endif /* IPA_CP_H */
4 changes: 4 additions & 0 deletions gcc/range-op-ptr.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1968,4 +1968,8 @@ range_op_table::initialize_pointer_ops ()
{
set (POINTER_PLUS_EXPR, op_pointer_plus);
set (POINTER_DIFF_EXPR, op_pointer_diff);
set (BIT_AND_EXPR, op_hybrid_and);
set (BIT_IOR_EXPR, op_hybrid_or);
set (MIN_EXPR, op_hybrid_min);
set (MAX_EXPR, op_hybrid_max);
}
18 changes: 14 additions & 4 deletions gcc/range-op.cc
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,23 @@ range_op_table::range_op_table ()
set (MINUS_EXPR, op_minus);
set (NEGATE_EXPR, op_negate);
set (MULT_EXPR, op_mult);

// Occur in both integer and pointer tables, but currently share
// integral implementation.
set (ADDR_EXPR, op_addr);
set (BIT_NOT_EXPR, op_bitwise_not);
set (BIT_XOR_EXPR, op_bitwise_xor);
set (BIT_AND_EXPR, op_bitwise_and);
set (BIT_IOR_EXPR, op_bitwise_or);
set (MIN_EXPR, op_min);
set (MAX_EXPR, op_max);

// These are in both integer and pointer tables, but pointer has a different
// implementation.
// If commented out, there is a hybrid version in range-op-ptr.cc which
// is used until there is a pointer range class. Then we can simply
// uncomment the operator here and use the unified version.

// set (BIT_AND_EXPR, op_bitwise_and);
// set (BIT_IOR_EXPR, op_bitwise_or);
// set (MIN_EXPR, op_min);
// set (MAX_EXPR, op_max);
}

// Instantiate a default range operator for opcodes with no entry.
Expand Down
2 changes: 1 addition & 1 deletion gcc/tree-ssa-structalias.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6833,7 +6833,7 @@ find_what_p_points_to (tree fndecl, tree p)
struct ptr_info_def *pi;
tree lookup_p = p;
varinfo_t vi;
prange vr;
value_range vr;
get_range_query (DECL_STRUCT_FUNCTION (fndecl))->range_of_expr (vr, p);
bool nonnull = vr.nonzero_p ();

Expand Down
1 change: 0 additions & 1 deletion gcc/value-range.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,6 @@ irange::verify_range ()
gcc_checking_assert (m_num_ranges == 0);
return;
}
gcc_checking_assert (supports_p (type ()));
gcc_checking_assert (m_num_ranges <= m_max_ranges);

// Legacy allowed these to represent VARYING for unknown types.
Expand Down
4 changes: 2 additions & 2 deletions gcc/value-range.h
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ irange::varying_compatible_p () const
const wide_int &u = m_base[1];
tree t = m_type;

if (m_kind == VR_VARYING)
if (m_kind == VR_VARYING && t == error_mark_node)
return true;

unsigned prec = TYPE_PRECISION (t);
Expand Down Expand Up @@ -1039,7 +1039,7 @@ irange::nonzero_p () const
inline bool
irange::supports_p (const_tree type)
{
return INTEGRAL_TYPE_P (type);
return INTEGRAL_TYPE_P (type) || POINTER_TYPE_P (type);
}

inline bool
Expand Down

0 comments on commit d7bb8ea

Please sign in to comment.