Removes implicit conversions in std::complex #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::complex<_Tp>` assumes that `int, double, long double` are explicitly convertible to `_Tp`. Currently, `std::complex<_Tp>` also assumes that: 1. `int` is implicitly convertible to `_Tp`, e.g., when using `complex<_Tp>(1)`. 2. `long double` can be attributed to a `_Tp` variable, e.g., when using `const _Tp __pi_2 = 1.5707963267948966192313216916397514L`. This PR removes assumptions (1) and (2), broadening the types `std::complex` supports. One example is the type `Eigen::Half` in https://eigen.tuxfamily.org/dox-devel/Half_8h_source.html. This type does not implement implicit conversions.
wangliu-iscas
pushed a commit
to plctlab/patchwork-gcc
that referenced
this pull request
Mar 27, 2023
Dear all, Here follows a patch that removes implicit type casts in std::complex. *Description:* The current implementation of `complex<_Tp>` assumes that `int, double, long double` are explicitly convertible to `_Tp`. Moreover, it also assumes that: 1. `int` is implicitly convertible to `_Tp`, e.g., when using `complex<_Tp>(1)`. 2. `long double` can be attributed to a `_Tp` variable, e.g., when using `const _Tp __pi_2 = 1.5707963267948966192313216916397514L`. This patch transforms the implicit casts (1) and (2) into explicit type casts. As a result, `std::complex` is now able to support more types. One example is the type `Eigen::Half` from https://eigen.tuxfamily.org/dox-devel/Half_8h_source.html which does not implement implicit type conversions. *ChangeLog:* libstdc++-v3/ChangeLog: * include/std/complex: *Patch:* fix_complex.diff. (Also at gcc-mirror/gcc#84) *OBS:* I didn't find a good reason for adding new tests or test results here since this is really a small upgrade (in my view) to std::complex. Sincerely, Weslley
|
This is a read-only mirror that is not managed by GCC developers. Pull requests in this read-only mirror will be ignored forever. If you wish to contribute to GCC please read: https://gcc.gnu.org/wiki/GettingStarted |
|
Thanks! I sent a contribution as instructed here: https://gcc.gnu.org/wiki/GettingStarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::complex<_Tp>assumes thatint, double, long doubleare explicitly convertible to_Tp. Currently,std::complex<_Tp>also assumes that:intis implicitly convertible to_Tp, e.g., when usingcomplex<_Tp>(1).long doublecan be attributed to a_Tpvariable, e.g., when usingconst _Tp __pi_2 = 1.5707963267948966192313216916397514L.This PR removes assumptions (1) and (2), broadening the types
std::complexsupports. One example is the typeEigen::Halfin https://eigen.tuxfamily.org/dox-devel/Half_8h_source.html. This type does not implement implicit conversions.