Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view resizing #11

Closed
gchp opened this issue Dec 6, 2014 · 1 comment
Closed

Fix view resizing #11

gchp opened this issue Dec 6, 2014 · 1 comment

Comments

@gchp
Copy link
Owner

gchp commented Dec 6, 2014

View resizing doesn't work well, need to fix this before we can get split views working. This will involve changing how the status bar is drawn too.

Maybe adding a bottom_line param to View. Then draw the status bar after the end of the view.
gchp added a commit that referenced this issue Dec 8, 2014
@gchp
Added bottom_line_num to View
71e5c55 
This makes the status bar draw at the end of the view all the time. Also
added the Ctrl-R keybinding for testing resizing.

This will more than likely need to be refactored later when the ViewTree
is added.

Refs #11
gchp added a commit that referenced this issue Dec 8, 2014
@gchp
Added bottom_line_num to View
f42a280 
This makes the status bar draw at the end of the view all the time. Also
added the Ctrl-R keybinding for testing resizing.

This will more than likely need to be refactored later when the ViewTree
is added.

Refs #11
gchp added a commit that referenced this issue Dec 8, 2014
@gchp
Removed bottom_line_num - added better solution
6afa000 
Size views based on the internal UIBuffer height instead.
Refs #11
@gchp
Copy link
Owner Author

gchp commented Dec 8, 2014

Fixed in 7a0e6b6

@gchp gchp closed this as completed Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gchp